From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24071: [PATCH] Refactor regex character class parsing in [:name:] Date: Fri, 29 Jul 2016 08:53:28 +0300 Message-ID: <83invpq9bb.fsf@gnu.org> References: <1469487245-11126-1-git-send-email-mina86@mina86.com> <83d1m0tq25.fsf@gnu.org> <87zip1t3gb.fsf@secretsauce.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1469771674 23486 80.91.229.3 (29 Jul 2016 05:54:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jul 2016 05:54:34 +0000 (UTC) Cc: 24071@debbugs.gnu.org, mina86@mina86.com To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 29 07:54:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bT0kV-0001N4-R6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jul 2016 07:54:20 +0200 Original-Received: from localhost ([::1]:57595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT0kP-0005z2-BV for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jul 2016 01:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT0kF-0005ys-U6 for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT0kE-0003St-42 for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:54:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT0kE-0003Sk-0H for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bT0kD-00055U-OO for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jul 2016 05:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24071-submit@debbugs.gnu.org id=B24071.146977162719536 (code B ref 24071); Fri, 29 Jul 2016 05:54:01 +0000 Original-Received: (at 24071) by debbugs.gnu.org; 29 Jul 2016 05:53:47 +0000 Original-Received: from localhost ([127.0.0.1]:49905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT0jy-000552-NP for submit@debbugs.gnu.org; Fri, 29 Jul 2016 01:53:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT0jw-00054p-Op for 24071@debbugs.gnu.org; Fri, 29 Jul 2016 01:53:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT0jn-0003HS-5m for 24071@debbugs.gnu.org; Fri, 29 Jul 2016 01:53:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT0jn-0003Gy-22; Fri, 29 Jul 2016 01:53:35 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4773 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bT0jm-0003Rj-7H; Fri, 29 Jul 2016 01:53:34 -0400 In-reply-to: <87zip1t3gb.fsf@secretsauce.net> (message from Dima Kogan on Thu, 28 Jul 2016 22:31:48 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121670 Archived-At: > From: Dima Kogan > Cc: Michal Nazarewicz , 24071@debbugs.gnu.org > Date: Thu, 28 Jul 2016 22:31:48 -0700 > > Eli Zaretskii writes: > > > If we are going to make some serious refactoring in regex.c, I think > > we should start with having a test suite for it. The > > dima_regex_embedded_modifiers branch, created by Dima Kogan (CC'ed) in > > the Emacs repository includes a suite taken from glibc. Dima, could > > you perhaps merge the parts of the test suite that can already be used > > to the master branch, so that we could use them to verify changes in > > regex.c? > > Hi. I just saw this. Do you still need me to get these merged? No, I think Michal already did that, although the stiff is not yet on the master branch. Thanks.