From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24449: Emacs 25.1 RC2: Byte compiler reports error in wrong place. Date: Sat, 17 Sep 2016 12:35:05 +0300 Message-ID: <83intu50om.fsf@gnu.org> References: <20160916113124.GB3630@acm.fritz.box> <83wpic3rpb.fsf@gnu.org> <20160916133352.GC3630@acm.fritz.box> <83twdf51al.fsf@gnu.org> <20160916183451.GE3630@acm.fritz.box> <83poo34qg5.fsf@gnu.org> <20160917082952.GA3410@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1474104980 6954 195.159.176.226 (17 Sep 2016 09:36:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Sep 2016 09:36:20 +0000 (UTC) Cc: 24449@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 17 11:36:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blC2g-0000zi-Fp for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Sep 2016 11:36:14 +0200 Original-Received: from localhost ([::1]:45396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blC2d-0001RW-Or for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Sep 2016 05:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blC2X-0001RQ-WB for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 05:36:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blC2U-0007jT-Qo for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 05:36:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blC2U-0007jO-NK for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 05:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1blC2U-0003Wp-Gx for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 05:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2016 09:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24449 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24449-submit@debbugs.gnu.org id=B24449.147410490913498 (code B ref 24449); Sat, 17 Sep 2016 09:36:02 +0000 Original-Received: (at 24449) by debbugs.gnu.org; 17 Sep 2016 09:35:09 +0000 Original-Received: from localhost ([127.0.0.1]:33699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blC1c-0003Ve-Rw for submit@debbugs.gnu.org; Sat, 17 Sep 2016 05:35:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blC1a-0003V7-Kj for 24449@debbugs.gnu.org; Sat, 17 Sep 2016 05:35:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blC1S-0007Di-5W for 24449@debbugs.gnu.org; Sat, 17 Sep 2016 05:35:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blC1S-0007DM-2h; Sat, 17 Sep 2016 05:34:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1489 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1blC1P-0000ZV-H6; Sat, 17 Sep 2016 05:34:56 -0400 In-reply-to: <20160917082952.GA3410@acm.fritz.box> (message from Alan Mackenzie on Sat, 17 Sep 2016 08:29:52 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123396 Archived-At: > Date: Sat, 17 Sep 2016 08:29:52 +0000 > Cc: 24449@debbugs.gnu.org > From: Alan Mackenzie > > 5. The change I made yesterday appears not to have made anything any > worse. Thanks, I guess that means you should push it. > What I would suggest should get done: we should make the column numbers > 0-based This should be a separate change, and before doing it, we should make sure to fix code that assumes the columns to be 1-based (e.g, what does "C-x `" do?). > suitable places to call `byte-compile-set-symbol-position' for > the error messages we see should be identified, the calls inserted, and > another bootstrap build done to see how much this helps. Sounds a good idea, thanks.