all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com
Subject: bug#25025: python-shell-calculate-command is wrong
Date: Sat, 26 Nov 2016 20:43:12 +0200	[thread overview]
Message-ID: <83inra13r3.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV--0ztEpiB1JxPcWDEs-faAfmZrhh9EaPSM6pZqR6mpW8A@mail.gmail.com> (message from Noam Postavsky on Fri, 25 Nov 2016 09:59:43 -0500)

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Fri, 25 Nov 2016 09:59:43 -0500
> Cc: Clément Pit--Claudel <clement.pit@gmail.com>, 
> 	25025@debbugs.gnu.org
> 
> >> > The python shell name is not passed to any underlying shell.
> >> > It is used to create a process, so it must not be quoted in anyway.
> >>
> >> Are you sure? Looking at the code, I see this:
> >>
> >>   (python-shell-make-comint
> >>       (or cmd (python-shell-calculate-command)) …)
> >>
> >> And python-shell-make-comint does this:
> >>
> >>   (split-string-and-unquote cmd)
> >>
> >> (ok, this is weird).  But still, if the command is "C:\Program Files\Python\python.exe", then we *do* need the shell quoting, right?
> >
> > The quoting needs to be done only where a shell command is created
> > that is about to be passed to a shell.  I believe in this case the
> > quoting is done too early.
> >
> 
> I think the whole command should be quoted with
> combine-and-quote-strings to balance the call to
> split-string-and-unquote.

Why not remove both of those calls?  Do you understand why they are
needed in that case?





  reply	other threads:[~2016-11-26 18:43 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  6:24 bug#25025: python-shell-calculate-command is wrong Fabrice Popineau
2016-11-25  7:03 ` Clément Pit--Claudel
2016-11-25  8:32   ` Eli Zaretskii
2016-11-25 14:44     ` Clément Pit--Claudel
2016-11-25 14:59     ` Noam Postavsky
2016-11-26 18:43       ` Eli Zaretskii [this message]
2016-11-27  0:50         ` Noam Postavsky
2016-11-27  2:35           ` Clément Pit--Claudel
2016-11-27 15:56           ` Eli Zaretskii
2016-11-27 16:06             ` npostavs
2016-11-27 16:12               ` Eli Zaretskii
2016-11-28  8:42                 ` Andreas Röhler
2016-11-28 14:15                   ` npostavs
2016-11-28 16:43                     ` Andreas Röhler
2016-11-30  0:39                       ` npostavs
2016-11-30  6:39                         ` Andreas Röhler
2016-11-30 17:12                           ` Clément Pit--Claudel
2016-11-30  0:36                 ` npostavs
2016-11-30  1:35                   ` Clément Pit--Claudel
2016-11-30  1:56                     ` npostavs
2016-11-30 15:55                       ` Eli Zaretskii
2016-11-30 22:10                         ` Noam Postavsky
2016-12-01 17:10                           ` Eli Zaretskii
2016-12-02  1:12                             ` npostavs
2016-12-02  7:35                               ` Eli Zaretskii
2016-12-02 14:16                                 ` Noam Postavsky
2016-12-02 14:51                                   ` Eli Zaretskii
2016-12-02 15:07                                     ` npostavs
2016-12-02 15:46                                       ` Eli Zaretskii
2016-12-02 16:15                                 ` Clément Pit--Claudel
2016-12-02 16:41                                   ` Noam Postavsky
2016-12-02 16:58                                     ` Clément Pit--Claudel
2016-12-09  5:29                                     ` npostavs
2017-08-16 11:08                                       ` npostavs
2017-08-16 14:32                                         ` Eli Zaretskii
2017-08-16 16:50                                           ` Noam Postavsky
2017-08-16 16:57                                             ` Eli Zaretskii
2017-08-16 19:27                                               ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83inra13r3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25025@debbugs.gnu.org \
    --cc=clement.pit@gmail.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.