all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: John Wiegley <jwiegley@gmail.com>, Le Wang <l26wang@gmail.com>
Cc: 25374@debbugs.gnu.org
Subject: bug#25374: 25.1.91; bug
Date: Fri, 06 Jan 2017 10:02:11 +0200	[thread overview]
Message-ID: <83inpsd3b0.fsf@gnu.org> (raw)
In-Reply-To: <m2pok0slbb.fsf@newartisans.com> (message from John Wiegley on Sun, 28 Aug 2011 00:51:56 +0800 (5 years, 18 weeks, 6 days ago))

> From: John Wiegley <jwiegley@gmail.com>
> Date: Sun, 28 Aug 2011 00:51:56 +0800 (5 years, 18 weeks, 6 days ago)
> 
> From: Le Wang <l26wang@gmail.com>
> 
> It doesn't look right to me that auto region selection is not
> accessible interactively.  The interactive "r" form is quite broken,
> so you may want to fix it in other interactive forms as well.  Unless
> there is a good reason you left it this way?

Sorry, I don't think I understand this part.  Please elaborate what is
broken in the interactive "r" form.

> -  (interactive "r")
> +  (interactive (if (use-region-p)
> +                   (list (region-beginning) (region-end))
> +                 (list nil nil)))

This is not an equivalent change: the previous code would use the
region even if it was not active (i.e. transient-mark-mode is off),
the new code will think there's no region in that case.





      reply	other threads:[~2017-01-06  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-27 16:51 bug#25374: 25.1.91; bug John Wiegley
2017-01-06  8:02 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83inpsd3b0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25374@debbugs.gnu.org \
    --cc=jwiegley@gmail.com \
    --cc=l26wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.