all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: 25525@debbugs.gnu.org
Subject: bug#25525: 25.1.90; add color highlighting to css mode
Date: Wed, 25 Jan 2017 17:51:23 +0200	[thread overview]
Message-ID: <83inp32l50.fsf@gnu.org> (raw)
In-Reply-To: <87mvefh8br.fsf@tromey.com> (message from Tom Tromey on Wed, 25 Jan 2017 01:06:48 -0700)

> From: Tom Tromey <tom@tromey.com>
> Date: Wed, 25 Jan 2017 01:06:48 -0700
> 
> This patch adds color highlighting to CSS mode.
> 
> In particular, this provides a new jit-lock function that recognizes the
> various forms of CSS color syntax, including some css-color-4 additions.
> 
> When such a color is seen, the background color of the text is set to
> the color itself.  In order to remain readable, the foreground is set to
> a contrasting color, and a box is put around the text (this helps
> distinguish colors that are close to the buffer's background color).
> 
> While doing this I noticed that css-mode was missing a few named colors
> specified by CSS, in particular:
> 
>     ("darkgrey" "darkslategrey" "dimgrey" "grey" "lightgrey"
>     "lightslategrey" "slategrey")
> 
> This patch fixes this problem as well.

Thanks.

I wonder whether it would make sense to reuse some existing data and
code here?

For example, tty-colors.el already has a (longer) list of colors with
suitable RGB values, so perhaps we should simply add the few missing
ones to that list, and then use that for CSS?

As another example, tty-colors.el also includes code for parsing and
converting color values (although perhaps not all of the formats you
support in your code).

As yet another example of existing functionality that you could
perhaps reuse, there's the :distant-foreground attribute of a face
that might help you with the issue of color contrast.

If you already considered all those and decided not to use them, could
you tell why?





  reply	other threads:[~2017-01-25 15:51 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  8:06 bug#25525: 25.1.90; add color highlighting to css mode Tom Tromey
2017-01-25 15:51 ` Eli Zaretskii [this message]
2017-01-25 17:25   ` Tom Tromey
2017-01-25 23:34     ` Tom Tromey
2017-01-26 16:05       ` Eli Zaretskii
2017-01-26 17:13         ` Tom Tromey
2017-01-26 19:32           ` Eli Zaretskii
2017-02-11  4:11             ` Tom Tromey
2017-01-26 17:17         ` Tom Tromey
2017-01-25 16:52 ` Glenn Morris
2017-01-25 20:23 ` Simen Heggestøyl
2017-01-25 20:41   ` Tom Tromey
2017-01-25 23:24   ` Tom Tromey
2017-01-26 18:25     ` Simen Heggestøyl
2017-02-11  4:16       ` Tom Tromey
2017-02-11 15:17       ` Tom Tromey
2017-02-17 19:29         ` Simen Heggestøyl
2017-03-04 17:55           ` Tom Tromey
2017-03-04 18:46             ` Simen Heggestøyl
2017-03-04 19:58               ` Tom Tromey
2017-03-05 18:28                 ` Simen Heggestøyl
     [not found]                   ` <871str3b48.fsf@tromey.com>
2017-03-20 21:28                     ` Tom Tromey
2017-03-22 22:07                     ` Tom Tromey
2017-03-29 18:27                       ` Simen Heggestøyl
2017-04-21  3:40                         ` Tom Tromey
2017-04-21  9:33                           ` Andreas Schwab
2017-04-22  0:44                             ` Tom Tromey
2017-04-22 15:07                           ` Simen Heggestøyl
2017-04-24 13:44                             ` Tom Tromey
2017-04-29  4:17                               ` Tom Tromey
2017-05-01 19:15                                 ` Simen Heggestøyl
2017-05-03 22:04                                   ` Tom Tromey
2017-05-01 21:25                                 ` Etienne Prud’homme
2017-05-03 22:03                                   ` Tom Tromey
2017-05-03 23:24                                     ` Etienne Prud’homme
2017-05-04  3:51                                       ` Tom Tromey
2017-03-05  2:42               ` Tom Tromey
2017-03-05 15:34                 ` Eli Zaretskii
2017-05-03 22:04 ` bug#25525: done Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83inp32l50.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25525@debbugs.gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.