From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Thu, 20 Apr 2017 22:38:05 +0300 Message-ID: <83inlyc1k2.fsf@gnu.org> References: <83a89gq3us.fsf@gnu.org> <87bmtjiv0w.fsf_-_@lifelogs.com> <83o9xjn06c.fsf@gnu.org> <87shmeb5ln.fsf_-_@lifelogs.com> <83y3w5z1ez.fsf@gnu.org> <87lgr6yakj.fsf@lifelogs.com> <87wpamww9k.fsf@lifelogs.com> <8337daggnj.fsf@gnu.org> <87d1cdwxt6.fsf@lifelogs.com> <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> <83h91og80k.fsf@gnu.org> <87pogbuhoe.fsf@lifelogs.com> <834lxndmd9.fsf@gnu.org> <87efwrug6z.fsf@lifelogs.com> <87r30qu5av.fsf@lifelogs.com> <874lxmtxyy.fsf@lifelogs.com> <87r30prvwt.fsf@lifelogs.com> <8337d4csez.fsf@gnu.org> <87r30nq9el.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492717059 21469 195.159.176.226 (20 Apr 2017 19:37:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Apr 2017 19:37:39 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 20 21:37:36 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1HtY-0005U9-7A for ged-emacs-devel@m.gmane.org; Thu, 20 Apr 2017 21:37:36 +0200 Original-Received: from localhost ([::1]:55688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1Hte-0003Fs-1Z for ged-emacs-devel@m.gmane.org; Thu, 20 Apr 2017 15:37:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1HtW-0003Fe-HL for emacs-devel@gnu.org; Thu, 20 Apr 2017 15:37:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1HtR-0004cv-Vi for emacs-devel@gnu.org; Thu, 20 Apr 2017 15:37:34 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1HtR-0004cj-Ry for emacs-devel@gnu.org; Thu, 20 Apr 2017 15:37:29 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3662 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d1HtP-0006uR-TI for emacs-devel@gnu.org; Thu, 20 Apr 2017 15:37:28 -0400 In-reply-to: <87r30nq9el.fsf@lifelogs.com> (message from Ted Zlatanov on Thu, 20 Apr 2017 13:24:50 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214155 Archived-At: > From: Ted Zlatanov > Date: Thu, 20 Apr 2017 13:24:50 -0400 > > On Wed, 19 Apr 2017 18:45:40 +0300 Eli Zaretskii wrote: > > EZ> The NEWS entry should mention the section in the manual which > EZ> describes these features. > > I think I did it right? Not sure what you mean. I just did "git pull", and your branch's NEWS doesn't mention the manual section where this is described. Something like "See the node 'FOO' in the ELisp manual for more details." Am I blind? > EZ> I would suggest to extract the common description of the > EZ> (BUFFER-OR-STRING START END CODING-SYSTEM NOERROR) form, so you could > EZ> have it only once, instead of repeating it with each function. > > I'm not sure how to make that look good in the texi docs. Is there an > existing convention for defining a data format that will be reused in > function definitions? Something like this at the beginning of the node: All of the functions described here accept argument lists of the form @code{(BUFFER-OR-STRING START END CODING-SYSTEM NOERROR)}, where BUFFER-OR-STRING ... > EZ> I think (file "FOO") is the best. (I understand that the file will be > EZ> submitted to GnuTLS functions for processing, is that right?) > > Since you and David agreed, I've made that the third allowed format. It > errors out for now. Should I use an internal buffer (not in the visible > list) and read into it, and then use the buffer data? Or should I use > emacs_open() etc. and actually implement a raw file read operation, > which should be a bit more secure and less subject to coding systems? I'm confused. I thought this form of an argument will cause the file name be passed to GnuTLS functions, and GnuTLS will then open the file and read its data. If that's not true, and Emacs needs to read the file anyway, then what's the purpose of having this form of the argument? How is it better than just reading the file into a temporary buffer and submitting the buffer to the function? I thought you wanted to avoid having the file's contents in Emacs's memory for security reasons.