all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: acm@muc.de, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: Trouble merging line-numbers branch into master
Date: Sat, 08 Jul 2017 11:04:45 +0300	[thread overview]
Message-ID: <83inj3l5gi.fsf@gnu.org> (raw)
In-Reply-To: <CAFyQvY3-JTfX_O=uFKhr=ws2MC58xM-48NwiXTn8QODZ+abC-A@mail.gmail.com> (message from Kaushal Modi on Fri, 07 Jul 2017 21:46:44 +0000)

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Fri, 07 Jul 2017 21:46:44 +0000
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> On Fri, Jul 7, 2017 at 5:41 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
> 
>  Presumably the lines in question were changed in one branch or the other (not
>  necessarily by messing with white space), and our git settings are suggesting
>  that you omit the spaces before tabs while you're futzing with those lines.
> 
>  As build-aux/git-hooks/pre-commit suggests, you can work around the problem
>  temporarily with the shell command 'git config core.whitespace -trailing-space'.
>  I don't recommend this setting in general, though.
> 
> I found the error useful. So when line-numbers branch is eventually merged, instead of ignoring/bypassing this
> error, I'd suggest that that tab+space+tab combo be fixed and that whole thing be made to contain only tabs
> or only spaces (my preference). 

I've just merged the branch, and didn't have any such problems.  In
the diffs I see no changes due to whitespace only, and the only merge
conflict I had, in NEWS, had nothing to do with whitespace and was
resolved without introducing any whitespace.

So I really don't understand what is this all about.  If SPC followed
by a TAB is detected when you merge, it was already there in master
before the merge, and the merge itself is not the problem.

In any case, if someone bumps into this issue, please do NOT fix
whitespace as part of very large commits (such as the one I just did),
because in such jumbo changesets it's very important to be able to
identify real changes, and too many whitespace changes get in the way.

> Slowly and gradually, as more merges and commits happen in future, all such mixtures of tabs+spaces will
> get removed.

They cannot be removed completely, because indentation doesn't always
end in a column whose number is an integral multiple of the tab width.



  reply	other threads:[~2017-07-08  8:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 15:43 Trouble merging line-numbers branch into master Kaushal Modi
2017-07-07 15:51 ` Noam Postavsky
2017-07-07 18:08   ` Kaushal Modi
2017-07-07 21:23 ` Alan Mackenzie
2017-07-07 21:38   ` Stefan Monnier
2017-07-07 21:41   ` Paul Eggert
2017-07-07 21:46     ` Kaushal Modi
2017-07-08  8:04       ` Eli Zaretskii [this message]
2017-07-08 12:05         ` Noam Postavsky
2017-07-08 12:46           ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83inj3l5gi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=acm@muc.de \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.