From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it.
Date: Mon, 24 Jul 2017 21:37:10 +0300 [thread overview]
Message-ID: <83inih7kbt.fsf@gnu.org> (raw)
In-Reply-To: <jwvvamhr9bw.fsf-monnier+Inbox@gnu.org> (message from Stefan Monnier on Mon, 24 Jul 2017 14:16:42 -0400)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: emacs-devel@gnu.org
> Date: Mon, 24 Jul 2017 14:16:42 -0400
>
> >> - the comment on the defvar isn't needed anyway: it's pretty clear why the
> >> defvar is used
> > It isn't clear to me, at least.
>
> How so?
Because just _looking_ at the code doesn't explain why it's there, and
its relation to autoloading is not immediately obvious.
> It silences the compiler warning, just like all such (defvar foo).
But this is not about silencing the compiler, this is about
autoloading.
next prev parent reply other threads:[~2017-07-24 18:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170723072843.23485.53761@vcs0.savannah.gnu.org>
[not found] ` <20170723072844.877FD22EF0@vcs0.savannah.gnu.org>
2017-07-23 13:28 ` [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it Stefan Monnier
2017-07-23 14:02 ` Michael Albinus
2017-07-24 16:57 ` Glenn Morris
2017-07-24 17:01 ` Eli Zaretskii
2017-07-24 17:29 ` Stefan Monnier
2017-07-24 18:04 ` Eli Zaretskii
2017-07-24 18:16 ` Stefan Monnier
2017-07-24 18:37 ` Eli Zaretskii [this message]
2017-07-24 20:05 ` Stefan Monnier
2017-07-24 18:20 ` Stefan Monnier
2017-07-24 18:43 ` Eli Zaretskii
2017-07-24 20:02 ` Stefan Monnier
2017-07-25 2:36 ` Eli Zaretskii
2017-07-25 3:22 ` Stefan Monnier
2017-07-25 5:18 ` Eli Zaretskii
2017-07-25 7:37 ` Michael Albinus
2017-07-25 13:56 ` Stefan Monnier
2017-07-26 16:54 ` Glenn Morris
2017-07-26 18:59 ` Eli Zaretskii
2017-07-24 17:26 ` Michael Albinus
2017-07-24 17:30 ` Stefan Monnier
2017-07-24 17:34 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83inih7kbt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.