From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28818: kmacro stepping: void-variable kmacro-step-edit-active Date: Mon, 16 Oct 2017 19:38:28 +0300 Message-ID: <83infff3p7.fsf@gnu.org> References: <83a80ukgsp.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1508172038 18201 195.159.176.226 (16 Oct 2017 16:40:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 16:40:38 +0000 (UTC) Cc: 28818@debbugs.gnu.org To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 18:40:32 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e48RD-00033t-QR for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 18:40:23 +0200 Original-Received: from localhost ([::1]:34073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48RL-0007MQ-AL for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 12:40:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48Pz-0006bp-VN for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:39:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e48Pu-0000TZ-BO for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:39:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35428) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e48Pu-0000TR-7Z for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e48Pt-0003mL-Vl for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 16:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28818 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28818-submit@debbugs.gnu.org id=B28818.150817193714513 (code B ref 28818); Mon, 16 Oct 2017 16:39:01 +0000 Original-Received: (at 28818) by debbugs.gnu.org; 16 Oct 2017 16:38:57 +0000 Original-Received: from localhost ([127.0.0.1]:44109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e48Pp-0003m1-Ho for submit@debbugs.gnu.org; Mon, 16 Oct 2017 12:38:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e48Pn-0003ln-OZ for 28818@debbugs.gnu.org; Mon, 16 Oct 2017 12:38:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e48Pf-0000Cu-A2 for 28818@debbugs.gnu.org; Mon, 16 Oct 2017 12:38:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48Pf-0000Cn-6r; Mon, 16 Oct 2017 12:38:47 -0400 Original-Received: from [176.228.60.248] (port=2042 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e48Pe-0005Kg-Lh; Mon, 16 Oct 2017 12:38:47 -0400 In-reply-to: (charles@aurox.ch) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138539 Archived-At: merge 18708 28818 close 28818 thanks > Date: Sun, 15 Oct 2017 20:40:49 +0200 > From: charles@aurox.ch (Charles A. Roelli) > CC: 28818@debbugs.gnu.org > > > Does the below fix this? > > > > diff --git a/lisp/kmacro.el b/lisp/kmacro.el > > index 582a58e..4abc571 100644 > > --- a/lisp/kmacro.el > > +++ b/lisp/kmacro.el > > @@ -937,7 +937,7 @@ kmacro-edit-lossage > > > > ;;; Single-step editing of keyboard macros > > > > -(defvar kmacro-step-edit-active) ;; step-editing active > > +(defvar kmacro-step-edit-active nil) ;; step-editing active > > (defvar kmacro-step-edit-new-macro) ;; storage for new macro > > (defvar kmacro-step-edit-inserting) ;; inserting into macro > > (defvar kmacro-step-edit-appending) ;; append to end of macro > > Yes it does. Thanks. Thanks, pushed. As a nice bonus, one more kmacro test now succeeds, as this bug is a duplicate of bug#18708.