From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28814: [BUMP, PATCH] (26.0.90; When *xref* window is needed, original window-switching intent is lost ) Date: Wed, 25 Oct 2017 18:11:01 +0300 Message-ID: <83inf38dq2.fsf@gnu.org> References: <87infjm3p3.fsf@gmail.com> <871slyi3lk.fsf_-_@gmail.com> <87lgk22ryu.fsf@gmail.com> <87fua91vis.fsf@gmail.com> <13af136e-12fb-4e8d-81ff-63424b1e1943@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1508944340 24917 195.159.176.226 (25 Oct 2017 15:12:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Oct 2017 15:12:20 +0000 (UTC) Cc: joaotavora@gmail.com, 28814@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 25 17:12:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7NLj-0004yS-DH for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 17:12:07 +0200 Original-Received: from localhost ([::1]:48748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7NLn-0007ZG-Oq for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 11:12:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7NLh-0007Xm-Hl for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7NLe-0003oG-SC for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:12:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7NLe-0003oC-OD for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e7NLe-0002fp-JN for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Oct 2017 15:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28814-submit@debbugs.gnu.org id=B28814.150894428610227 (code B ref 28814); Wed, 25 Oct 2017 15:12:02 +0000 Original-Received: (at 28814) by debbugs.gnu.org; 25 Oct 2017 15:11:26 +0000 Original-Received: from localhost ([127.0.0.1]:33466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7NL3-0002es-NU for submit@debbugs.gnu.org; Wed, 25 Oct 2017 11:11:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7NL2-0002eg-5F for 28814@debbugs.gnu.org; Wed, 25 Oct 2017 11:11:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7NKu-0003DW-BQ for 28814@debbugs.gnu.org; Wed, 25 Oct 2017 11:11:18 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7NKu-0003DO-7N; Wed, 25 Oct 2017 11:11:16 -0400 Original-Received: from [176.228.60.248] (port=4892 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e7NKr-0006i7-PJ; Wed, 25 Oct 2017 11:11:16 -0400 In-reply-to: <13af136e-12fb-4e8d-81ff-63424b1e1943@yandex.ru> (message from Dmitry Gutov on Wed, 25 Oct 2017 03:24:58 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138964 Archived-At: > Cc: 28814@debbugs.gnu.org, eliz@gnu.org > From: Dmitry Gutov > Date: Wed, 25 Oct 2017 03:24:58 +0300 > > On 10/23/17 11:03 PM, João Távora wrote: > > > I read the discussion you pointed me to me by Dmitry in > > http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01235.html. > > > > Eli, If I understand your concerns there, then the first and third > > patches I proposed shouldn't in any way interfere with your use of > > *xref*-related facilities. If anything, they should improve it. > > Overall, I don't have strong objections, so if Eli is fine with the new > behavior all around, I don't mind getting them in (with maybe a few > modifications), and hopefully we'll reach some better solutions by the > next release. Sorry, guys: I will have to take you several steps back, because I got lost in the details of your discussion. I understand that the motivation for changing the existing solution for the "disappearing XREF buffer" was the unexpected or even incorrect behavior when the "C-x 4" variety of the commands is invoked. That is, the existing code would display the definition in the original window, not in "the other" window (which is taken by the XREF buffer). And the original solution was to display the definition in the window where the XREF buffer was displayed, thus making it "disappear". Is that correct? If so, then the easiest solution IMO would be to pop up one more window, i.e. behave as if the window displaying the XREF buffer didn't exist. That would both keep the contract of "C-x 4" and leave the XREF buffer visible. As for quitting the XREF buffer when it's no longer needed: how about 'q', like other similar modes do, or some variety thereof? "C-u RET" is too odd, almost outlandish in Emacs. If the above solves the remaining issues, and if you have no other problems, can we have patches to that effect? And then the next question would be: what branch to install this on? Thanks, and sorry for keeping silence until now.