From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29349: [Patch] Bug 29349: read_key_sequence is only partially recursive. This is a bug. Date: Mon, 20 Nov 2017 05:33:28 +0200 Message-ID: <83ine5ei9j.fsf@gnu.org> References: <20171118093843.GA3819@ACM> <20171119123456.GA4576@ACM> <20171119155908.GB4576@ACM> <83tvxqdwyy.fsf@gnu.org> <20171119174521.GB9922@ACM> <83mv3idu4w.fsf@gnu.org> <20171119204121.GE9922@ACM> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511148865 25080 195.159.176.226 (20 Nov 2017 03:34:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Nov 2017 03:34:25 +0000 (UTC) Cc: 29349@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 20 04:34:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGcqd-0005l9-2v for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Nov 2017 04:34:15 +0100 Original-Received: from localhost ([::1]:55248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGcqh-0000Yx-00 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 22:34:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGcqU-0000Ww-Su for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 22:34:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGcqQ-0001zM-Av for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 22:34:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGcqQ-0001zC-7I for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 22:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGcqP-0002Pa-Oe for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 22:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2017 03:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29349-submit@debbugs.gnu.org id=B29349.15111488289250 (code B ref 29349); Mon, 20 Nov 2017 03:34:01 +0000 Original-Received: (at 29349) by debbugs.gnu.org; 20 Nov 2017 03:33:48 +0000 Original-Received: from localhost ([127.0.0.1]:48104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGcqB-0002P7-Vl for submit@debbugs.gnu.org; Sun, 19 Nov 2017 22:33:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGcqA-0002Ov-WD for 29349@debbugs.gnu.org; Sun, 19 Nov 2017 22:33:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGcq1-0001k1-4r for 29349@debbugs.gnu.org; Sun, 19 Nov 2017 22:33:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGcq1-0001jw-1U; Sun, 19 Nov 2017 22:33:37 -0500 Original-Received: from [176.228.60.248] (port=2535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eGcq0-0005eu-C0; Sun, 19 Nov 2017 22:33:36 -0500 In-reply-to: <20171119204121.GE9922@ACM> (message from Alan Mackenzie on Sun, 19 Nov 2017 20:41:21 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140132 Archived-At: > Date: Sun, 19 Nov 2017 20:41:21 +0000 > Cc: 29349@debbugs.gnu.org > From: Alan Mackenzie > > > > With the patch applied, the C-down-mouse-3 survives in the raw key > > > buffer, enabling `describe-key-briefly' to do the Right Thing. It does > > > this by collecting the menu processing's mouse events in a separate > > > buffer, then copying that buffer to the main one afterwards. > > > OK, but then (a) please install the patch on master, not on the > > release branch, .... > > I'll do that, but probably not tonight. > > > .... and (b) why do we need the followup patch -- with the mouse-1 > > events injected into the sequence the "translation" looks correct and > > even educational. > > I don't think it looks correct. The C-down-mouse-3 which exists as an > essential part of the key sequence has been overwritten in the > "translation". That's not what I see here, with your patch applied in keyboard.c, I see this: (translated from ) at that spot runs the command indent-pp-sexp (found in global-map), which is an interactive compiled Lisp function in `lisp-mode.el'. So C-down-mouse-3 is still there, we just have each click in the menus injected into the sequence. What did you see after applying that patch. > The other thing is that if mouse-movements get into the raw event buffer > (which I've seen, but for some reason amn't seeing any more) the > "translated from" could become objectionably long. I don't see that as a problem. > I think the "translated from" bit is intended to document a sequence the > user is aware of (such as a double click) being translated into a > different sequence she's aware of (such as a single click). And that's exactly what happens in this case. > The mouse-1, I believe, is more part of the user's subconsciousness > rather than awareness. But those mouse-1 clicks are real.