all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 29456@debbugs.gnu.org, tom@tromey.com, monnier@iro.umontreal.ca
Subject: bug#29456: [PATCH] Add command for cycling between CSS color formats
Date: Mon, 27 Nov 2017 19:07:56 +0200	[thread overview]
Message-ID: <83indv645v.fsf@gnu.org> (raw)
In-Reply-To: <1511709711.2341.0@smtp.gmail.com> (message from Simen Heggestøyl on Sun, 26 Nov 2017 16:21:51 +0100)

> Date: Sun, 26 Nov 2017 16:21:51 +0100
> From: Simen Heggestøyl <simenheg@gmail.com>
> Cc: Tom Tromey <tom@tromey.com>, Stefan Monnier <monnier@iro.umontreal.ca>
> 
> The attached patch adds a new command 'css-cycle-color-format' to CSS
> mode, for cycling between color formats (e.g. "black" => "#000000" =>
> "rgb(0, 0, 0)" => "black"), bound to 'C-c C-f'.

Thanks.

These functions are confusingly similar to, but subtly different from,
the similar functions in color.el, and in general the whole system of
color conversions used by Emacs for its display needs.  Here's a
tell-tale example:

    (css--web-color-to-4-dpc "#fff")
      => "#ffffffffffff"
but
    (apply 'color-rgb-to-hex (color-name-to-rgb "#fff"))
      => "#f0f0f0f0f0f0"

The latter follows the X color definitions, so why does css-mode.el
need a different interpretation of the hex-RGB notation?

My fear is that someone will mix css-mode functions with those from
elsewhere in Emacs, and will bump into confusing and contradicting
results.  Is it possible to avoid that?





  parent reply	other threads:[~2017-11-27 17:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 15:21 bug#29456: [PATCH] Add command for cycling between CSS color formats Simen Heggestøyl
2017-11-26 17:53 ` Tom Tromey
2017-11-27 17:07 ` Eli Zaretskii [this message]
2017-11-27 17:41   ` Tom Tromey
2017-11-27 18:11     ` Eli Zaretskii
2017-11-27 18:35       ` Tom Tromey
2017-11-27 18:43         ` Eli Zaretskii
2017-11-28 18:33           ` Simen Heggestøyl
2017-11-28 20:57             ` Simen Heggestøyl
2017-12-10 12:46               ` Simen Heggestøyl
2017-12-10 18:09                 ` Eli Zaretskii
2017-12-17  9:32                   ` Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83indv645v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=29456@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=simenheg@gmail.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.