From: Eli Zaretskii <eliz@gnu.org>
To: Allen Li <vianchielfaura@gmail.com>
Cc: schwab@suse.de, 29189@debbugs.gnu.org
Subject: bug#29189: 25.3; Dired does not work with binary filenames
Date: Sat, 02 Dec 2017 11:01:01 +0200 [thread overview]
Message-ID: <83indp1p2q.fsf@gnu.org> (raw)
In-Reply-To: <CAJr1M6c+0=-77pK2sMgG00MUTUzA1tfMGiNo8XU1apEC1AMd3g@mail.gmail.com> (message from Allen Li on Fri, 1 Dec 2017 21:21:14 -0800)
> From: Allen Li <vianchielfaura@gmail.com>
> Date: Fri, 1 Dec 2017 21:21:14 -0800
> Cc: Andreas Schwab <schwab@suse.de>, handa@gnu.org, 29189@debbugs.gnu.org
>
> I applied this patch to master (0b6f4f2c60) and it fixes the bug and
> doesn't crash Emacs immediately. The code also looks right, but I am
> not familiar with Emacs's C code. A few questions.
>
> Why do we have to handle multibyte strings in this function
> decode_coding? (I found the answer in the docs)
decode_coding needs to work when a series of raw bytes is inserted
into a multibyte buffer (which happens in the Dired case).
> Can you briefly explain how Emacs internally stores unibyte and
> multibyte strings? (I found the answer in character.h)
Right, the details are in that header file.
> After doing the above research, I can more confidently say this is
> right, but having an expert opinion would be nice.
Thanks for proofreading the patch and testing it. I'm waiting for
Handa-san to comment on it.
next prev parent reply other threads:[~2017-12-02 9:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 9:03 bug#29189: 25.3; Dired does not work with binary filenames Allen Li
2017-11-07 10:00 ` Andreas Schwab
2017-11-07 17:08 ` Eli Zaretskii
2017-11-08 5:12 ` Allen Li
2017-11-08 6:22 ` Allen Li
2017-11-08 8:44 ` Eli Zaretskii
2017-11-11 6:59 ` Allen Li
2017-11-11 8:20 ` Eli Zaretskii
2017-11-11 14:18 ` Eli Zaretskii
2017-11-11 15:21 ` Eli Zaretskii
2017-11-16 6:31 ` Allen Li
2017-11-16 16:00 ` Eli Zaretskii
2017-11-18 14:42 ` Eli Zaretskii
2017-11-20 9:48 ` Andreas Schwab
2017-11-20 18:15 ` Eli Zaretskii
2017-11-24 8:52 ` Eli Zaretskii
2017-12-01 8:41 ` Eli Zaretskii
2017-12-09 9:03 ` Eli Zaretskii
2017-12-15 9:09 ` Eli Zaretskii
2017-12-02 5:21 ` Allen Li
2017-12-02 9:01 ` Eli Zaretskii [this message]
2018-01-05 22:16 ` Stefan Monnier
[not found] ` <83h8rz9x6k.fsf@gnu.org>
[not found] ` <jwvbmi72fak.fsf-monnier+emacs@gnu.org>
2018-01-06 16:04 ` Eli Zaretskii
2018-01-07 15:20 ` Stefan Monnier
2018-01-07 17:53 ` Eli Zaretskii
[not found] <CADbSrJytKAysg4DRNR4iJD5JJbn7iwi_28Gh_oabaE-rnVyqLw@mail.gmail.com>
2018-09-09 0:31 ` Allen Li
2018-09-09 6:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83indp1p2q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29189@debbugs.gnu.org \
--cc=schwab@suse.de \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.