From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Mon, 22 Jan 2018 17:52:34 +0200 Message-ID: <83inbtriv1.fsf@gnu.org> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> <83bmhpt12i.fsf@gnu.org> <867escw93p.fsf@phe.ftfl.ca> <86vafwumqp.fsf@phe.ftfl.ca> <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> <83372zryx3.fsf@gnu.org> <4928e09c-e747-8754-973f-7b358ca3f5e7@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516636320 30687 195.159.176.226 (22 Jan 2018 15:52:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 15:52:00 +0000 (UTC) Cc: jrm@ftfl.ca, ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 22 16:51:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edeNa-000667-Fi for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 16:51:26 +0100 Original-Received: from localhost ([::1]:49380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edePa-0002vM-SY for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 10:53:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edeOw-0002r3-Nq for emacs-devel@gnu.org; Mon, 22 Jan 2018 10:52:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edeOt-0005Al-Jg for emacs-devel@gnu.org; Mon, 22 Jan 2018 10:52:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edeOt-0005AZ-Ff; Mon, 22 Jan 2018 10:52:47 -0500 Original-Received: from [176.228.60.248] (port=3284 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1edeOs-0007Lv-QE; Mon, 22 Jan 2018 10:52:47 -0500 In-reply-to: <4928e09c-e747-8754-973f-7b358ca3f5e7@cs.ucla.edu> (message from Paul Eggert on Sun, 21 Jan 2018 22:52:02 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222140 Archived-At: > Cc: jrm@ftfl.ca, ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, > emacs-devel@gnu.org > From: Paul Eggert > Date: Sun, 21 Jan 2018 22:52:02 -0800 > > Eli Zaretskii wrote: > > Why doesn't copy-file (or qcopy_acl?) use acl_errno_valid, as we do in > > set-file-acl? Is there a reason for this inconsistency? > > set-file-acl is documented to return t on success, nil on ordinary failure, and > (this part is undocumented) it signals an error on a serious failure. > acl_errno_valid is used to decide whether the error is serious. > > copy-file simply signals an error on failure; its return value is undocumented. > So it doesn't have the three possibilities that set-file-acl has. I didn't mean to change the API, I meant to ask why doesn't copy-file use acl_errno_valid, and if that says the error just means ACLs aren't supported in this case, silently gives up on copying ACLs? The return value doesn't need to change. We use set-file-acl when we need a more fancy copying, which we do in Lisp, so why not in the primitive?