From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: What improvements would be truly useful? Date: Thu, 08 Mar 2018 15:20:58 +0200 Message-ID: <83ina6puth.fsf@gnu.org> References: <87inaiss6l.fsf@web.de> <6FCF6ACA-4F29-4B6B-BE9D-D7130C6E9495@gnu.org> <87fu5moe4c.fsf@web.de> <877eqyocro.fsf@web.de> <83zi3uz4nb.fsf@gnu.org> <0b1dd3fa-e0b0-ed20-a256-dd92d1c1826f@dancol.org> <8bc3c4c7-dfc7-987a-95e7-bd309e2326c6@cs.ucla.edu> <03118DC0-39DA-4AB5-980E-A33809B9A5EE@raeburn.org> <86578165-1b41-e75c-7180-84d8edefc44b@grinta.net> <83o9k2s4xw.fsf@gnu.org> <65dafef7-3e1f-ba67-6717-c369033533a3@grinta.net> <831sgxrvsq.fsf@gnu.org> <9e3a1c0b-325f-29c6-eb78-dd4b0106e17b@grinta.net> <836067rd97.fsf@gnu.org> <1ba2560c-d23f-e85a-586d-9cf474ec0719@grinta.net> <83zi3jpxpq.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520515210 15885 195.159.176.226 (8 Mar 2018 13:20:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Mar 2018 13:20:10 +0000 (UTC) Cc: daniele@grinta.net, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 08 14:20:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etvSm-0003yC-B2 for ged-emacs-devel@m.gmane.org; Thu, 08 Mar 2018 14:20:04 +0100 Original-Received: from localhost ([::1]:38821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etvUp-0007Yo-6y for ged-emacs-devel@m.gmane.org; Thu, 08 Mar 2018 08:22:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etvTp-0007XV-Df for emacs-devel@gnu.org; Thu, 08 Mar 2018 08:21:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etvTl-00072C-1q for emacs-devel@gnu.org; Thu, 08 Mar 2018 08:21:09 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etvTk-000726-UV; Thu, 08 Mar 2018 08:21:04 -0500 Original-Received: from [176.228.60.248] (port=3650 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1etvTj-0004gU-Iq; Thu, 08 Mar 2018 08:21:04 -0500 In-reply-to: (message from Philipp Stephani on Wed, 07 Mar 2018 21:45:46 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223491 Archived-At: > From: Philipp Stephani > Date: Wed, 07 Mar 2018 21:45:46 +0000 > Cc: Daniele Nicolodi , emacs-devel@gnu.org > > If you have ideas for how to achieve that, I'd be interested to hear > them. > > By adding a gtkterm.c, that does the same as w32term.c, just for GTK, without referring to X.org in any way? > The cleanup would then consist in removing all GTK functionality from xterm.c once gtkterm.c is stable. (I guess you meant removing GTK-related portions of xfns.c as well?) If you look at these two files, you will see that the GTK-specific snippets in them are a few and far between. Most of the code is generic. So I think making separate gtkterm.c/gtkfns.c will risk duplicating a lot of code, something we already have with w32 and ns ports, and such duplication is undesirable. But maybe I'm missing something. My understanding of this sub-thread was that the idea was to separate GTK _architecturally_, not just making it yet another display back-end.