bug#32945: [PATCH] Prefer delete-char

bug#32945: [PATCH] Prefer delete-char

[Alex Branham]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi -

This is a trivial change that silences the byte compiler warning in
lisp/eshell/em-rebind.el.

Thanks for all your work on Emacs!
Alex

From 40563de898d99a81d05d3d1585f753e20f815b60 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 5 Oct 2018 09:07:13 -0500
Subject: [PATCH] ; lisp/eshell/em-rebind.el (eshell-delete-backward-char):
 Prefer delete-char

---
 lisp/eshell/em-rebind.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/eshell/em-rebind.el b/lisp/eshell/em-rebind.el
index e6f04b68e0..064dcc762d 100644
--- a/lisp/eshell/em-rebind.el
+++ b/lisp/eshell/em-rebind.el
@@ -223,7 +223,7 @@ lock it at that."
   (interactive "P")
   (let ((count (prefix-numeric-value n)))
     (if (eshell-point-within-input-p (- (point) count))
-	(delete-backward-char count n)
+	(delete-char (- count) n)
       (beep))))

 (defun eshell-delchar-or-maybe-eof (arg)
--
2.19.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#32945: [PATCH] Prefer delete-char

[Eli Zaretskii]

> From: Alex Branham <alex.branham@gmail.com>
> Date: Fri, 05 Oct 2018 09:11:05 -0500
> 
> This is a trivial change that silences the byte compiler warning in
> lisp/eshell/em-rebind.el.

Thanks, pushed to the emacs-26 branch.

bug#32945: [PATCH] Prefer delete-char

[Glenn Morris]

Alex Branham wrote:

> This is a trivial change that silences the byte compiler warning in
> lisp/eshell/em-rebind.el.

Since eshell-delete-backward-char acts as a replacement for
delete-backward-char in eshell, it's never been obvious to me whether
such a change is the right thing to do.