From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33294: xwidget-insert crashes Emacs Date: Fri, 09 Nov 2018 16:56:41 +0200 Message-ID: <83in16b8pi.fsf@gnu.org> References: <838t25cxft.fsf@gnu.org> <8336sccgob.fsf@gnu.org> <83wopnbp5s.fsf@gnu.org> <877ehntu92.fsf@gmail.com> <83sh0bbe52.fsf@gnu.org> <83r2fubsq1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541775382 10797 195.159.176.226 (9 Nov 2018 14:56:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Nov 2018 14:56:22 +0000 (UTC) Cc: gazally@runbox.com, rpluim@gmail.com, lg.zevlg@gmail.com, 33294@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 09 15:56:17 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL8Ck-0002aT-6Q for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 15:56:14 +0100 Original-Received: from localhost ([::1]:34600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL8Eq-00081a-8o for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 09:58:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL8EZ-0007zO-BB for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:58:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gL8EV-0004dt-Vp for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:58:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gL8EU-0004cr-Ae for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:58:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gL8EU-0007Ii-7F for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Nov 2018 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33294-submit@debbugs.gnu.org id=B33294.154177543327991 (code B ref 33294); Fri, 09 Nov 2018 14:58:02 +0000 Original-Received: (at 33294) by debbugs.gnu.org; 9 Nov 2018 14:57:13 +0000 Original-Received: from localhost ([127.0.0.1]:43870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL8Dh-0007HP-9u for submit@debbugs.gnu.org; Fri, 09 Nov 2018 09:57:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL8Dc-0007HA-P1 for 33294@debbugs.gnu.org; Fri, 09 Nov 2018 09:57:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gL8DU-00034y-G6 for 33294@debbugs.gnu.org; Fri, 09 Nov 2018 09:57:03 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL8DS-00034R-Kj; Fri, 09 Nov 2018 09:57:00 -0500 Original-Received: from [176.228.60.248] (port=3338 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gL8DS-0002Tg-0c; Fri, 09 Nov 2018 09:56:58 -0500 In-reply-to: (message from Stefan Monnier on Fri, 09 Nov 2018 08:29:48 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152223 Archived-At: > From: Stefan Monnier > Cc: rpluim@gmail.com, lg.zevlg@gmail.com, gazally@runbox.com, > 33294@debbugs.gnu.org > Date: Fri, 09 Nov 2018 08:29:48 -0500 > > > Can you tell what are the guidelines for putting a PVEC object into > > the "impossible" category in the context of type-of? > > The "impossible" category is for when such objects can never be passed > to `type-of`, typically because they are not available to Elisp. Well, then 'xwidget' and 'xwidget-view' are definitely NOT "impossible", since we have make-xwidget and xwidget-view-lookup. > Accordingly, I just installed the patch below into emacs-26. You did? > diff --git a/src/data.c b/src/data.c > index 8d58cbd941..eea9ccedbb 100644 > --- a/src/data.c > +++ b/src/data.c > @@ -276,10 +276,12 @@ for example, (type-of 1) returns `integer'. */) > } > case PVEC_MODULE_FUNCTION: > return Qmodule_function; > - /* "Impossible" cases. */ > case PVEC_XWIDGET: > - case PVEC_OTHER: > + return Qxwidget; > case PVEC_XWIDGET_VIEW: > + return Qxwidget_view; > + /* "Impossible" cases. */ > + case PVEC_OTHER: > case PVEC_SUB_CHAR_TABLE: > case PVEC_FREE: ; > } > @@ -3756,6 +3758,8 @@ syms_of_data (void) > DEFSYM (Qfont_entity, "font-entity"); > DEFSYM (Qfont_object, "font-object"); > DEFSYM (Qterminal, "terminal"); > + DEFSYM (Qxwidget, "xwidget"); > + DEFSYM (Qxwidget_view, "xwidget-view"); > > DEFSYM (Qdefun, "defun"); Evgeny, does this patch solve your original problem?