From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: gazally@runbox.com, rpluim@gmail.com, lg.zevlg@gmail.com,
33294@debbugs.gnu.org
Subject: bug#33294: xwidget-insert crashes Emacs
Date: Fri, 09 Nov 2018 16:56:41 +0200 [thread overview]
Message-ID: <83in16b8pi.fsf@gnu.org> (raw)
In-Reply-To: <jwvin16wfjv.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Fri, 09 Nov 2018 08:29:48 -0500)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: rpluim@gmail.com, lg.zevlg@gmail.com, gazally@runbox.com,
> 33294@debbugs.gnu.org
> Date: Fri, 09 Nov 2018 08:29:48 -0500
>
> > Can you tell what are the guidelines for putting a PVEC object into
> > the "impossible" category in the context of type-of?
>
> The "impossible" category is for when such objects can never be passed
> to `type-of`, typically because they are not available to Elisp.
Well, then 'xwidget' and 'xwidget-view' are definitely NOT
"impossible", since we have make-xwidget and xwidget-view-lookup.
> Accordingly, I just installed the patch below into emacs-26.
You did?
> diff --git a/src/data.c b/src/data.c
> index 8d58cbd941..eea9ccedbb 100644
> --- a/src/data.c
> +++ b/src/data.c
> @@ -276,10 +276,12 @@ for example, (type-of 1) returns `integer'. */)
> }
> case PVEC_MODULE_FUNCTION:
> return Qmodule_function;
> - /* "Impossible" cases. */
> case PVEC_XWIDGET:
> - case PVEC_OTHER:
> + return Qxwidget;
> case PVEC_XWIDGET_VIEW:
> + return Qxwidget_view;
> + /* "Impossible" cases. */
> + case PVEC_OTHER:
> case PVEC_SUB_CHAR_TABLE:
> case PVEC_FREE: ;
> }
> @@ -3756,6 +3758,8 @@ syms_of_data (void)
> DEFSYM (Qfont_entity, "font-entity");
> DEFSYM (Qfont_object, "font-object");
> DEFSYM (Qterminal, "terminal");
> + DEFSYM (Qxwidget, "xwidget");
> + DEFSYM (Qxwidget_view, "xwidget-view");
>
> DEFSYM (Qdefun, "defun");
Evgeny, does this patch solve your original problem?
next prev parent reply other threads:[~2018-11-09 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 21:13 bug#33294: xwidget-insert crashes Emacs Evgeny Zajcev
2018-11-07 4:40 ` Eli Zaretskii
2018-11-07 16:16 ` Andy Moreton
2018-11-08 9:45 ` Eli Zaretskii
2018-11-08 13:01 ` Andy Moreton
[not found] ` <CAO=W_ZqJZ0APsO1skAs+1vh8KXs+JWR7YAiHNKuWV3VdmDmU8g@mail.gmail.com>
2018-11-08 4:54 ` Eli Zaretskii
2018-11-08 13:44 ` Evgeny Zajcev
2018-11-08 14:49 ` Eli Zaretskii
2018-11-08 16:21 ` Robert Pluim
2018-11-08 18:47 ` Eli Zaretskii
2018-11-08 20:15 ` Stefan Monnier
2018-11-09 7:44 ` Eli Zaretskii
2018-11-09 13:16 ` Robert Pluim
2018-11-09 13:29 ` Stefan Monnier
2018-11-09 13:46 ` Robert Pluim
2018-11-09 14:37 ` Stefan Monnier
2018-11-09 14:57 ` Robert Pluim
2018-11-09 14:56 ` Eli Zaretskii [this message]
2018-11-09 16:11 ` Stefan Monnier
2018-11-12 14:44 ` Evgeny Zajcev
2018-11-12 16:11 ` Eli Zaretskii
2018-11-13 11:43 ` Evgeny Zajcev
2018-11-16 8:32 ` Eli Zaretskii
2018-11-24 8:15 ` Eli Zaretskii
2018-11-26 14:02 ` Robert Pluim
2018-11-26 16:27 ` Eli Zaretskii
2018-11-27 7:54 ` Eli Zaretskii
2018-11-27 9:33 ` Robert Pluim
2018-11-27 8:43 ` Robert Pluim
2018-11-27 9:12 ` Eli Zaretskii
2018-11-09 18:09 ` Glenn Morris
2018-11-10 2:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83in16b8pi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33294@debbugs.gnu.org \
--cc=gazally@runbox.com \
--cc=lg.zevlg@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.