From: Eli Zaretskii <eliz@gnu.org>
To: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
Cc: 33990@debbugs.gnu.org
Subject: bug#33990: 27.0.50; image-transform-fit-to-height/-width violates assert
Date: Sat, 19 Jan 2019 10:29:11 +0200 [thread overview]
Message-ID: <83imylaw4o.fsf@gnu.org> (raw)
In-Reply-To: <87va2p8uu7.fsf@turtle-trading.net> (message from Benjamin Riefenstahl on Tue, 15 Jan 2019 22:38:40 +0100)
> From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
> Cc: 33990@debbugs.gnu.org
> Date: Tue, 15 Jan 2019 22:38:40 +0100
>
> Eli Zaretskii writes:
> > Can you propose a patch that would implement your suggestion?
>
> It looks like my analysis was wrong. The problem is rather that
> create-image applies a default scaling, when :scale is not given. This
> depends on the font size (only if char-width > 10 pixels), which
> explains why it happens on my laptop but not on my desktop machine. I
> guess create-image is targeting image resources like toolbar buttons,
> where it may be a good idea to scale the images with the fonts for
> so-called "hidpi" displays. But for image-mode the situation is
> different and I at least do not want that behaviour.
>
> I attach three patches, the first is a minimal change that fixes the
> problem for me. The second adds to the doc string of create-image,
> because I think that its behaviour is unexpected enough to warrant
> highlighting. The third makes the image-mode transform parameters
> buffer-local, because that seems more appropriate and even complies with
> the doc string form image-transform-rotation better. This third patch
> changes behaviour, though, so maybe a second opinion is in order.
>
> The patches are against master, I haven't tested if they apply against
> emacs-26. Let me know if there is something that needs to be changed.
Thanks, this LGTM. I will wait for a few days for comments, and pushd
these if no objections are heard.
I understand these are not recent regressions? If so, I think the
master branch is where they should go. But if you think the bug is
grave enough, I could consider them for the emacs-26 branch instead.
next prev parent reply other threads:[~2019-01-19 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 17:26 bug#33990: 27.0.50; image-transform-fit-to-height/-width violates assert Benjamin Riefenstahl
2019-01-05 18:13 ` Eli Zaretskii
2019-01-06 9:12 ` Benjamin Riefenstahl
2019-01-12 11:45 ` Eli Zaretskii
2019-01-14 18:40 ` Benjamin Riefenstahl
2019-01-14 18:53 ` Eli Zaretskii
2019-01-15 21:38 ` Benjamin Riefenstahl
2019-01-19 8:29 ` Eli Zaretskii [this message]
2019-01-19 17:21 ` Benjamin Riefenstahl
2019-01-25 8:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imylaw4o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33990@debbugs.gnu.org \
--cc=b.riefenstahl@turtle-trading.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.