From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34290: [PATCH] checkdoc byte compile warnings Date: Sat, 02 Feb 2019 18:06:22 +0200 Message-ID: <83imy2w4xt.fsf@gnu.org> References: <87zhre9opq.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="214349"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34290@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 02 17:14:45 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpxwH-000taF-N8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Feb 2019 17:14:41 +0100 Original-Received: from localhost ([127.0.0.1]:43871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpxwG-0005G2-DB for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Feb 2019 11:14:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpxw3-00051R-UB for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:14:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpxos-0001CS-2o for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpxor-0001C8-Uz for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gpxor-0006fi-PR for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2019 11:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Feb 2019 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34290-submit@debbugs.gnu.org id=B34290.154912361825636 (code B ref 34290); Sat, 02 Feb 2019 16:07:01 +0000 Original-Received: (at 34290) by debbugs.gnu.org; 2 Feb 2019 16:06:58 +0000 Original-Received: from localhost ([127.0.0.1]:56530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpxoo-0006fQ-J0 for submit@debbugs.gnu.org; Sat, 02 Feb 2019 11:06:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpxom-0006fE-Am for 34290@debbugs.gnu.org; Sat, 02 Feb 2019 11:06:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpxoZ-00011c-Ox; Sat, 02 Feb 2019 11:06:47 -0500 Original-Received: from [176.228.60.248] (port=1601 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gpxoY-0001Zf-By; Sat, 02 Feb 2019 11:06:43 -0500 In-reply-to: <87zhre9opq.fsf@gmail.com> (message from Alex Branham on Sat, 02 Feb 2019 09:47:45 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155022 Archived-At: > From: Alex Branham > Date: Sat, 02 Feb 2019 09:47:45 -0600 > > The attached patch fixes the byte compiler warnings that checkdoc issues > currently by declaring the functions for the byte compiler. It also > removes some old XEmacs compatibility code. Thanks. Can you explain the purpose of requiring lisp-mnt inside a function, as opposed to at the top level? The latter would then remove the need for using declare-function, I think. AFAIU, declare-function is useful when the function in question is auto-loaded, but we don't want to load its package unconditionally, e.g. because that function is used only in a small part of the package being compiled. None of which seems to be the case here, or did I miss something?