From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Changing dictionary while flyspell-buffer is running Date: Thu, 28 Feb 2019 19:50:05 +0200 Message-ID: <83imx3kdki.fsf@gnu.org> References: <874l8ztmgk.fsf@posteo.de> <87lg29sfxp.fsf@posteo.de> <87sgw8145o.fsf@posteo.de> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="219331"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rms@gnu.org, emacs-devel@gnu.org To: Titus von der Malsburg Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 18:50:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzPpb-000ux2-M9 for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2019 18:50:51 +0100 Original-Received: from localhost ([127.0.0.1]:44010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzPpa-00062v-LJ for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2019 12:50:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzPpP-00061S-Uo for emacs-devel@gnu.org; Thu, 28 Feb 2019 12:50:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzPpM-00040l-1h; Thu, 28 Feb 2019 12:50:39 -0500 Original-Received: from [176.228.60.248] (port=4247 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzPpC-0008Qv-3U; Thu, 28 Feb 2019 12:50:26 -0500 In-reply-to: <87sgw8145o.fsf@posteo.de> (message from Titus von der Malsburg on Thu, 28 Feb 2019 13:36:03 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233704 Archived-At: > From: Titus von der Malsburg > Date: Thu, 28 Feb 2019 13:36:03 +0100 > Cc: emacs-devel@gnu.org > > Below is a patch for ispell.el that adds a hook that is run before > `ispell-set-spellchecker-params'. Functions on this hook of course need > to be careful not to trigger an infinite recursion when they call Ispell > functions like `ispell-change-dictionary'. There is a note on that in > the documentation of the hook. Thanks, please accompany this with a suitable change in NEWS which announces this new feature. > +(defvar ispell-before-setting-spellchecker-params-hook nil > + "Normal hook run before setting spellchecker parameters. This single line doesn't tell in enough detail when the hook is run. "Before setting spellchecker parameters" does not necessarily explain itself clearly enough, because the reader doesn't necessarily know where these parameters are set in the sequence of actions performed for spell-checking. Please add more explanations about that. In particular, I think it's important to understand whether this is called before each invocation of the spellchecker, or just some of them.