From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34671: 27.0.50; Outdated code listings in (elisp) Example Major Modes Date: Fri, 01 Mar 2019 12:15:48 +0200 Message-ID: <83imx2j3xn.fsf@gnu.org> References: <87bm2yqyhj.fsf@tcd.ie> <877edmqy19.fsf@tcd.ie> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="253703"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34671@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 01 11:17:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzfE6-0013r4-KP for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 11:17:11 +0100 Original-Received: from localhost ([127.0.0.1]:34820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzfE5-0002n0-EE for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 05:17:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzfE0-0002mu-9i for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:17:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzfDy-0000wS-FH for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:17:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42269) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzfDy-0000w9-AS for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gzfDy-0004kG-0V for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Mar 2019 10:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34671 X-GNU-PR-Package: emacs Original-Received: via spool by 34671-submit@debbugs.gnu.org id=B34671.155143537118171 (code B ref 34671); Fri, 01 Mar 2019 10:17:01 +0000 Original-Received: (at 34671) by debbugs.gnu.org; 1 Mar 2019 10:16:11 +0000 Original-Received: from localhost ([127.0.0.1]:55813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzfD8-0004j0-AL for submit@debbugs.gnu.org; Fri, 01 Mar 2019 05:16:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzfD6-0004in-8G for 34671@debbugs.gnu.org; Fri, 01 Mar 2019 05:16:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzfD0-0000aj-Vf; Fri, 01 Mar 2019 05:16:03 -0500 Original-Received: from [176.228.60.248] (port=1661 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzfD0-0004V0-JR; Fri, 01 Mar 2019 05:16:02 -0500 In-reply-to: <877edmqy19.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155922 Archived-At: > From: "Basil L. Contovounesios" > Date: Tue, 26 Feb 2019 17:06:58 +0000 > > "Basil L. Contovounesios" writes: > > > Some of the examples in '(elisp) Example Major Modes' do not reflect the > > current code in lisp/textmodes/text-mode.el and > > lisp/emacs-lisp/lisp-mode.el. Furthermore, the indentation of the > > lisp-mode-map listing in the manual is off due to a tab character in its > > Texinfo source. > > > > Patch(es) to follow. > > I attach said patches; WDYT? Thanks. > The first patch reconciles the code listings in the manual with the > current state of the corresponding libraries. This part is definitely OK, please push to the emacs-26 branch. > The second patch enables lexical-binding in text-mode.el along with some > minor aesthetic changes. I don't see the need for parts of this patch. Enabling lexical-binding is OK, but it should be a separate change unrelated to this bug report. And I'm not sure I see the reason for the other changes, nor even agree with them. In particular, please modify whitespace only where you actually make other non-trivial changes. > The last patch fulfils an old promise in the manual to eventually forgo > setting indent-line-function in text-mode, which is considered > redundant. What if the user customizes the default values, shouldn't text-mode reset that in the buffer where it is turned on?