From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 34671@debbugs.gnu.org
Subject: bug#34671: 27.0.50; Outdated code listings in (elisp) Example Major Modes
Date: Fri, 01 Mar 2019 12:15:48 +0200 [thread overview]
Message-ID: <83imx2j3xn.fsf@gnu.org> (raw)
In-Reply-To: <877edmqy19.fsf@tcd.ie> (contovob@tcd.ie)
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Tue, 26 Feb 2019 17:06:58 +0000
>
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
> > Some of the examples in '(elisp) Example Major Modes' do not reflect the
> > current code in lisp/textmodes/text-mode.el and
> > lisp/emacs-lisp/lisp-mode.el. Furthermore, the indentation of the
> > lisp-mode-map listing in the manual is off due to a tab character in its
> > Texinfo source.
> >
> > Patch(es) to follow.
>
> I attach said patches; WDYT?
Thanks.
> The first patch reconciles the code listings in the manual with the
> current state of the corresponding libraries.
This part is definitely OK, please push to the emacs-26 branch.
> The second patch enables lexical-binding in text-mode.el along with some
> minor aesthetic changes.
I don't see the need for parts of this patch. Enabling
lexical-binding is OK, but it should be a separate change unrelated to
this bug report. And I'm not sure I see the reason for the other
changes, nor even agree with them. In particular, please modify
whitespace only where you actually make other non-trivial changes.
> The last patch fulfils an old promise in the manual to eventually forgo
> setting indent-line-function in text-mode, which is considered
> redundant.
What if the user customizes the default values, shouldn't text-mode
reset that in the buffer where it is turned on?
next prev parent reply other threads:[~2019-03-01 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 16:57 bug#34671: 27.0.50; Outdated code listings in (elisp) Example Major Modes Basil L. Contovounesios
2019-02-26 17:06 ` Basil L. Contovounesios
2019-03-01 10:15 ` Eli Zaretskii [this message]
2019-03-01 19:46 ` Basil L. Contovounesios
2019-03-02 7:39 ` Eli Zaretskii
2019-03-02 11:36 ` Basil L. Contovounesios
2019-03-02 12:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imx2j3xn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34671@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.