From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: tabulated-list sort icon is reversed Date: Sat, 02 Mar 2019 13:53:01 +0200 Message-ID: <83imx1h4rm.fsf@gnu.org> References: <87d0v1lsns.fsf@fastmail.fm> <532F6D74-E21C-45A2-B85B-01133DE1E8A1@scratch.space> <6e662c5b-3d04-2157-6712-aadcb6077f2b@gmail.com> <83a7j0pzbh.fsf@gnu.org> <83sgwpm92r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="84185"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Philippe Vaucher Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 02 13:01:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h03Kn-000LkI-KZ for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 13:01:41 +0100 Original-Received: from localhost ([127.0.0.1]:53159 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h03Kk-0003SA-6M for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 07:01:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h03Ka-0003QR-PS for emacs-devel@gnu.org; Sat, 02 Mar 2019 07:01:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h03Ca-0005P9-Gb; Sat, 02 Mar 2019 06:53:13 -0500 Original-Received: from [176.228.60.248] (port=2218 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h03Ca-0006Mo-4e; Sat, 02 Mar 2019 06:53:12 -0500 In-reply-to: (message from Philippe Vaucher on Thu, 28 Feb 2019 08:55:47 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233761 Archived-At: > From: Philippe Vaucher > Date: Thu, 28 Feb 2019 08:55:47 +0100 > Cc: Emacs developers > > * lisp/emacs-lisp/tabulated-list.el: add customization group, add > defcustoms. Please use the ChangeLog style in the commit log messages; CONTRIBUTE has the details. > +(defcustom tabulated-list-sort-icon-asc ?▼ > + "Icon to display when sort order is ascending." > + :group 'tabulated-list > + :type 'character) > + > +(defcustom tabulated-list-sort-icon-desc ?▲ > + "Icon to display when sort order is descending." > + :group 'tabulated-list > + :type 'character) > + > +(defcustom tabulated-list-glyphless-sort-icon-asc ?v > + "Glyphless icon to display when sort order is ascending." > + :group 'tabulated-list > + :type 'character) > + > +(defcustom tabulated-list-glyphless-sort-icon-desc ?^ > + "Glyphless icon to display when sort order is descending." > + :group 'tabulated-list > + :type 'character) The doc strings for these options are too laconic, they should tell what they are used for, and explain when the "glyphless" indicators will be used instead of the other kind (and calling the "glyphless" ones "icons" only adds to the confusion, so please don't). Also, please always include :version tags with new options. > - (aset table 9650 (cons nil "^")) > - (aset table 9660 (cons nil "v")) > + (aset table tabulated-list-sort-icon-desc (cons nil (char-to-string tabulated-list-glyphless-sort-icon-desc))) > + (aset table tabulated-list-sort-icon-asc (cons nil (char-to-string tabulated-list-glyphless-sort-icon-asc))) Please break these long lines into shorter ones. Finally, these changes should be accompanied by a suitable entry in NEWS and by updates for the user manual, since this changes user-visible behavior.