Re: tabulated-list sort icon is reversed

[Eli Zaretskii <eliz@gnu.org>]

> From: Philippe Vaucher <philippe.vaucher@gmail.com>
> Date: Thu, 28 Feb 2019 08:55:47 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> * lisp/emacs-lisp/tabulated-list.el: add customization group, add
>   defcustoms.

Please use the ChangeLog style in the commit log messages; CONTRIBUTE
has the details.

> +(defcustom tabulated-list-sort-icon-asc ?▼
> +  "Icon to display when sort order is ascending."
> +  :group 'tabulated-list
> +  :type 'character)
> +
> +(defcustom tabulated-list-sort-icon-desc ?▲
> +  "Icon to display when sort order is descending."
> +  :group 'tabulated-list
> +  :type 'character)
> +
> +(defcustom tabulated-list-glyphless-sort-icon-asc ?v
> +  "Glyphless icon to display when sort order is ascending."
> +  :group 'tabulated-list
> +  :type 'character)
> +
> +(defcustom tabulated-list-glyphless-sort-icon-desc ?^
> +  "Glyphless icon to display when sort order is descending."
> +  :group 'tabulated-list
> +  :type 'character)

The doc strings for these options are too laconic, they should tell
what they are used for, and explain when the "glyphless" indicators
will be used instead of the other kind (and calling the "glyphless"
ones "icons" only adds to the confusion, so please don't).  Also,
please always include :version tags with new options.

> -    (aset table 9650 (cons nil "^"))
> -    (aset table 9660 (cons nil "v"))
> +    (aset table tabulated-list-sort-icon-desc (cons nil (char-to-string tabulated-list-glyphless-sort-icon-desc)))
> +    (aset table tabulated-list-sort-icon-asc (cons nil (char-to-string tabulated-list-glyphless-sort-icon-asc)))

Please break these long lines into shorter ones.

Finally, these changes should be accompanied by a suitable entry in
NEWS and by updates for the user manual, since this changes
user-visible behavior.