all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 33016@debbugs.gnu.org, bauer.klaus.dieter@gmail.com
Subject: bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist
Date: Fri, 12 Apr 2019 11:44:49 +0300	[thread overview]
Message-ID: <83imvjmx32.fsf@gnu.org> (raw)
In-Reply-To: <87ftqo9hnk.fsf@gmail.com> (message from Noam Postavsky on Thu, 11 Apr 2019 20:44:15 -0400)

> From: Noam Postavsky <npostavs@gmail.com>
> Cc: 33016@debbugs.gnu.org,  bauer.klaus.dieter@gmail.com
> Date: Thu, 11 Apr 2019 20:44:15 -0400
> 
> > OK.  That diff includes some unrelated stuff, though -- you didn't
> > mean to install it as is, right?
> 
> Ah, I left in the .gdbinit change completely by accident.  The other
> stuff is related, but wasn't cleaned up properly yet.  Here's a proper patch:

Thanks.

> +                    ;; On Windows, "nul.FOO" is the empty file for any
> +                    ;; FOO, in any directory.  So this passes Emacs'
> +                    ;; test for the file's existence, and ensures we
> +                    ;; hit an error in the w32 process spawn code.
> +                    (call-process "c:/nul.exe")

What happened to mentioning the null device in this comment?

> +                     (setq when-entered-debugger -1))))

This should be internal-when-entered-debugger, right?  And the same in
the other test.





  reply	other threads:[~2019-04-12  8:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 12:55 bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist Klaus-Dieter Bauer
2018-10-11 14:22 ` Eli Zaretskii
2018-10-19  8:03   ` Klaus-Dieter Bauer
2018-10-19  8:30     ` Eli Zaretskii
2019-04-08 18:34 ` Noam Postavsky
2019-04-08 18:58   ` Eli Zaretskii
2019-04-09 14:13     ` Noam Postavsky
2019-04-09 14:33       ` Eli Zaretskii
2019-04-10 21:58         ` Noam Postavsky
2019-04-11 14:04           ` Eli Zaretskii
2019-04-11 17:34             ` Noam Postavsky
2019-04-11 17:55               ` Eli Zaretskii
2019-04-12  0:44                 ` Noam Postavsky
2019-04-12  8:44                   ` Eli Zaretskii [this message]
2019-04-12 18:20                     ` Noam Postavsky
2019-04-12 18:44                       ` Eli Zaretskii
2019-04-15 12:21                         ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83imvjmx32.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33016@debbugs.gnu.org \
    --cc=bauer.klaus.dieter@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.