From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Renaming non-X x_* identifiers Date: Tue, 16 Apr 2019 17:58:04 +0300 Message-ID: <83imvegfpf.fsf@gnu.org> References: <87wokp4okn.fsf@gmail.com> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> <87d0lpvq6n.fsf_-_@gmail.com> <83r2a5keo7.fsf@gnu.org> <87pnppu4ox.fsf@gmail.com> <83muktk9xb.fsf@gnu.org> <875zrhtg2i.fsf@gmail.com> <83ftqkk7lr.fsf@gnu.org> <877ebwvatg.fsf@gmail.com> <83y34cin3g.fsf@gnu.org> <87y34ctrs1.fsf@gmail.com> <83h8azianr.fsf@gnu.org> <83v9zehed2.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="5696"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 16:58:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGPXu-0001PJ-FX for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 16:58:50 +0200 Original-Received: from localhost ([127.0.0.1]:38078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGPXt-0007hP-Ha for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 10:58:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGPXL-0007hH-VX for emacs-devel@gnu.org; Tue, 16 Apr 2019 10:58:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGPXK-0007un-2J; Tue, 16 Apr 2019 10:58:14 -0400 Original-Received: from [176.228.60.248] (port=1953 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hGPXG-0005BB-Su; Tue, 16 Apr 2019 10:58:11 -0400 In-reply-to: (message from Stefan Monnier on Tue, 16 Apr 2019 08:55:38 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235520 Archived-At: > From: Stefan Monnier > Date: Tue, 16 Apr 2019 08:55:38 -0400 > > I was thinking about it from the point of the view of maintenance rather > than efficiency: it removes the need to know which slots might be NULL > (and hence require a test) and which not, so it should simplify > the code. I'm not sure this simplification is for the better. It makes _writing_ the code easier, but it gets in the way of _reading_ it, because one must go and see what the hook does, especially when investigating some issue for a configuration where the hook makes no sense. This is C, not Lisp, so it's usually impossible to eval something on the spot and see that the hook points to some function whose name talks for itself. You must fire up a debugger, stop it at the right place, and only then you know. I find this less convenient than just reading the source, it feels like a C++ program, not a C program.