From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Mon, 22 Apr 2019 21:27:45 +0300 Message-ID: <83imv56gke.fsf@gnu.org> References: <87ftq96gww.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="225517"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 31138@debbugs.gnu.org, dgutov@yandex.ru To: Alex Gramiak Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 22 20:41:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIdsr-000wby-DO for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 20:41:41 +0200 Original-Received: from localhost ([127.0.0.1]:41157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIdsq-0002s9-Bw for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 14:41:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIdsa-0002dO-9t for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 14:41:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIdgc-0003wO-0e for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 14:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38042) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIdgb-0003vr-Td for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 14:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIdgb-0002S5-LJ for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 14:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2019 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.15559577049381 (code B ref 31138); Mon, 22 Apr 2019 18:29:01 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 22 Apr 2019 18:28:24 +0000 Original-Received: from localhost ([127.0.0.1]:51586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIdfy-0002RE-OI for submit@debbugs.gnu.org; Mon, 22 Apr 2019 14:28:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIdfx-0002R2-1J for 31138@debbugs.gnu.org; Mon, 22 Apr 2019 14:28:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIdfj-0003RV-KD; Mon, 22 Apr 2019 14:28:09 -0400 Original-Received: from [176.228.60.248] (port=2573 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hIdff-0005pF-6d; Mon, 22 Apr 2019 14:28:05 -0400 In-reply-to: <87ftq96gww.fsf@gmail.com> (message from Alex Gramiak on Mon, 22 Apr 2019 12:20:15 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158071 Archived-At: > From: Alex Gramiak > Cc: Eli Zaretskii , Dmitry Gutov > Date: Mon, 22 Apr 2019 12:20:15 -0600 > > P.S. Would applying the following diff be okay? It's a simple > optimization that avoids an overflow check (the sizeof comparison is > optimized out even in -O0) I don't understand what this optimizes, since AFAIU INT_TO_INTEGER already produces a fixnum if possible. It sounds like a step backward, because the whole point of INT_TO_INTEGER is that the programmer doesn't need to bother about the magnitude of the value. > in the usual case of a JSON integer fitting into an EMACS_INT. Not sure what you meant by "usual case". Does this include a 32-bit build of Emacs?