From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c) Date: Sun, 09 Jun 2019 16:56:41 +0300 Message-ID: <83imtec15y.fsf@gnu.org> References: <837e9vclzj.fsf@gnu.org> <87lfya28uj.fsf_-_@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="69559"; mail-complaints-to="usenet@blaine.gmane.org" Cc: , 36143@debbugs.gnu.org, stefan@marxist.se To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 09 15:57:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZyJq-000HzT-0O for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Jun 2019 15:57:10 +0200 Original-Received: from localhost ([::1]:35986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZyJo-0008T3-LZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Jun 2019 09:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53132) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZyJj-0008Sj-ET for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 09:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZyJi-0005CJ-Iv for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 09:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41570) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZyJi-0005CA-Fd for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 09:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZyJi-0007wh-CK for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 09:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2019 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36143-submit@debbugs.gnu.org id=B36143.156008861830534 (code B ref 36143); Sun, 09 Jun 2019 13:57:02 +0000 Original-Received: (at 36143) by debbugs.gnu.org; 9 Jun 2019 13:56:58 +0000 Original-Received: from localhost ([127.0.0.1]:55114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZyJe-0007wO-4A for submit@debbugs.gnu.org; Sun, 09 Jun 2019 09:56:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZyJa-0007w9-6I for 36143@debbugs.gnu.org; Sun, 09 Jun 2019 09:56:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZyJU-000563-Py; Sun, 09 Jun 2019 09:56:48 -0400 Original-Received: from [176.228.60.248] (port=4626 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZyJU-0005vB-7U; Sun, 09 Jun 2019 09:56:48 -0400 In-reply-to: <87lfya28uj.fsf_-_@gmail.com> (message from Noam Postavsky on Sun, 09 Jun 2019 09:20:52 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160279 Archived-At: > From: Noam Postavsky > Date: Sun, 09 Jun 2019 09:20:52 -0400 > Cc: , Stefan Kangas > > Oh, I also didn't realize C sources were supposed to be TABified. Maybe > .dir-locals.el should have an explicit (indent-tabs-mode . t) setting > under c-mode? It'd be fine with me, but maybe others will object. I think it's okay to indent new C code with spaces, but when a few lines are modified in an otherwise TAB-indented block, that makes the source unaligned when reindented, so IMO should be avoided. And in this case, it was even more extreme: a line was modified only very slightly, so changing whitespace for only that single line was IMO gross.