From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 7555f93: Remove src/macuvs.h from Git repository Date: Sat, 22 Jun 2019 12:34:25 +0300 Message-ID: <83imsyneu6.fsf@gnu.org> References: <20190621220118.16051.70712@vcs0.savannah.gnu.org> <20190621220121.8B68D209DE@vcs0.savannah.gnu.org> <10o92qqxla.fsf@fencepost.gnu.org> <83y31unkc3.fsf@gnu.org> <06994830-a4f7-bb64-78ab-9b3f42c82f91@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="116395"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rgm@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 22 11:36:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hecRE-000U2n-NL for ged-emacs-devel@m.gmane.org; Sat, 22 Jun 2019 11:36:00 +0200 Original-Received: from localhost ([::1]:39644 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hecRD-0005zP-P5 for ged-emacs-devel@m.gmane.org; Sat, 22 Jun 2019 05:35:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59435) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hecPs-0005gY-8I for emacs-devel@gnu.org; Sat, 22 Jun 2019 05:34:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hecPq-0005ME-5Z; Sat, 22 Jun 2019 05:34:34 -0400 Original-Received: from [176.228.60.248] (port=4073 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hecPo-000087-G9; Sat, 22 Jun 2019 05:34:33 -0400 In-reply-to: <06994830-a4f7-bb64-78ab-9b3f42c82f91@gmx.at> (message from martin rudalics on Sat, 22 Jun 2019 10:23:07 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238031 Archived-At: > Cc: rgm@gnu.org, emacs-devel@gnu.org > From: martin rudalics > Date: Sat, 22 Jun 2019 10:23:07 +0200 > > >>> Was having src/macuvs.h in the repository causing a problem? > >>> It has changed twice since 2014. > >> > >> Not a major problem, no. I made the change because Lars ran into > >> something; perhaps he can chime in. > > > > So I think we should put it back, and we should this time have a > > comment explaining why it is in Git although it's a generated file. > > I recall that I ran into something like Bug#18955 when src/macuvs.h > changed and was not really able to fix that without some annoying > surgery. According to the discussion in bug#18955, that problem was solved long ago, twice. So I'm not sure we should be afraid of that now.