From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 36315@debbugs.gnu.org, pipcet@gmail.com
Subject: bug#36315: 27.0.50; SVG transparency handling is inaccurate
Date: Tue, 25 Jun 2019 19:54:52 +0300 [thread overview]
Message-ID: <83imstli5f.fsf@gnu.org> (raw)
In-Reply-To: <wl7e9apor4.wl-mituharu@math.s.chiba-u.ac.jp> (message from YAMAMOTO Mitsuharu on Tue, 25 Jun 2019 08:06:23 +0900)
> Date: Tue, 25 Jun 2019 08:06:23 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Cc: pipcet@gmail.com,
> 36315@debbugs.gnu.org
>
> > The patch looks quite large. Do we gain anything significant, apart
> > of the appraisal of librsvg developers?
>
> 1. The current librsvg generates gdk-pixbuf via cairo image surface.
> So we can avoid unnecessarily intermediate data structure and
> roundtrip of alpha-component processing using cairo directly.
> 2. If configured --with-cairo, we can do further shortcut. This is
> included in the patch attached to this mail. Pip's patch is also
> reflected.
> 3. Image transformations can be applied when rendering to the cairo
> surface, not after generating bitmaps. So we can take advantage of
> outline format and get better results of scaling. This is not in
> the patch. Probably it should be done by a separate commit after
> general image transformation code has been stabilized.
Maybe it's just me, but I'm uneasy to bypass librsvg and call Cairo
directly for manipulating SVG images. Why doesn't librsvg provide a
way to do this via its own APIs?
Does anyone else think it's unusual to make such direct calls to what
is essentially a lower-level library?
> > I've built the patch on Windows (you forgot cairo_surface_destroy, so
> > I needed to add it), but the result is strange, or maybe I don't
> > understand what is expected. I don't see any rectangle of color
> > #f00000, I see the entire frame with black background, and a few
> > characters in other colors.
>
> When I tested Pip's test case, I started with emacs -Q -rv to avoid
> text becomes invisible. I could see a red rectangle on X11. Do you
> see such a rectangle without my patch?
Yes, I see an orange rectangle (a square, actually, I think).
next prev parent reply other threads:[~2019-06-25 16:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 20:26 bug#36315: 27.0.50; SVG transparency handling is inaccurate Pip Cet
2019-06-20 20:46 ` Pip Cet
2019-06-22 20:56 ` Alan Third
2019-06-24 7:56 ` YAMAMOTO Mitsuharu
2019-06-24 8:17 ` YAMAMOTO Mitsuharu
2019-06-24 16:24 ` Pip Cet
2019-06-24 17:41 ` Eli Zaretskii
2019-06-24 23:06 ` YAMAMOTO Mitsuharu
2019-06-25 16:54 ` Eli Zaretskii [this message]
2019-06-25 18:44 ` Alan Third
2019-06-25 18:55 ` Eli Zaretskii
2019-06-25 23:48 ` YAMAMOTO Mitsuharu
2019-06-26 0:12 ` Lars Ingebrigtsen
2019-06-26 15:57 ` Eli Zaretskii
2019-06-27 3:33 ` YAMAMOTO Mitsuharu
2019-06-27 14:16 ` Eli Zaretskii
2019-06-30 6:12 ` YAMAMOTO Mitsuharu
2019-06-30 14:26 ` Eli Zaretskii
2019-07-01 3:46 ` YAMAMOTO Mitsuharu
2019-07-01 14:11 ` Eli Zaretskii
2019-07-01 16:25 ` Pip Cet
2019-07-02 2:32 ` Eli Zaretskii
2019-07-02 9:46 ` YAMAMOTO Mitsuharu
2019-07-02 14:26 ` Eli Zaretskii
2020-08-21 13:04 ` Lars Ingebrigtsen
2020-08-21 15:04 ` Alan Third
2020-08-22 13:29 ` Lars Ingebrigtsen
2020-08-22 16:00 ` Alan Third
2020-12-18 0:49 ` bug#36315: Incorrect SVG color Qiantan Hong
2020-12-18 15:00 ` Alan Third
2020-12-18 15:47 ` Qiantan Hong
2020-12-18 15:51 ` Qiantan Hong
2020-12-18 16:42 ` Qiantan Hong
2020-12-18 18:04 ` Alan Third
2020-12-18 18:16 ` Alan Third
2020-12-19 0:24 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imstli5f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36315@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.