From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Crashes in "C-h h"
Date: Tue, 02 Jul 2019 05:31:11 +0300
Message-ID: <83imsldv68.fsf@gnu.org>
References: <83y31hes6r.fsf@gnu.org> <mvm1rz9pzn7.fsf@suse.de>
 <83r279epwe.fsf@gnu.org>
 <CAOqdjBfAfLuAUj67LnFx-4tD2g0tUUuA-_Le6scQPWJeD2eo2w@mail.gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="147849"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: schwab@suse.de, eggert@cs.ucla.edu, emacs-devel@gnu.org
To: Pip Cet <pipcet@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 02 05:36:36 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hi9au-000cJF-18
	for ged-emacs-devel@m.gmane.org; Tue, 02 Jul 2019 05:36:36 +0200
Original-Received: from localhost ([::1]:48094 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hi9ar-0006z7-2P
	for ged-emacs-devel@m.gmane.org; Mon, 01 Jul 2019 23:36:34 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50301)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hi8Zr-0004aj-6h
 for emacs-devel@gnu.org; Mon, 01 Jul 2019 22:31:30 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39804)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hi8Zq-0003TW-9V; Mon, 01 Jul 2019 22:31:26 -0400
Original-Received: from [176.228.60.248] (port=4498 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hi8Zp-0004E0-J9; Mon, 01 Jul 2019 22:31:26 -0400
In-reply-to: <CAOqdjBfAfLuAUj67LnFx-4tD2g0tUUuA-_Le6scQPWJeD2eo2w@mail.gmail.com>
 (message from Pip Cet on Mon, 1 Jul 2019 15:40:49 +0000)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:238281
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/238281>

> From: Pip Cet <pipcet@gmail.com>
> Date: Mon, 1 Jul 2019 15:40:49 +0000
> Cc: Andreas Schwab <schwab@suse.de>, eggert@cs.ucla.edu, emacs-devel@gnu.org
> 
> > >           if (XFIXNUM (repertory) == charset_id)
> > >
> > > Looks like repertory is nil.
> >
> > Yes, that part is clear.  The question is why...
> 
> Is there a problem simply testing FIXNUMP in this place? If I'm
> reading this correctly, repertory may be nil, but it might also be a
> char table, which might, by sheer accident, have XFIXNUM_RAW
> (repertory) == charset_id, so it looks like a bug that was caught, not
> caused, by the recent XFIXNUM change.

Yes, see what I eventually pushed (only now, as the gnu.org machines
went down yesterday when I needed them).

Thanks.