From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Patch]: Allow overlay arrows to be inserted before the text at column zero rather than splatting it.
Date: Sun, 18 Aug 2019 19:29:37 +0300 [thread overview]
Message-ID: <83imqumo7i.fsf@gnu.org> (raw)
In-Reply-To: <20190818161530.GB31509@ACM> (message from Alan Mackenzie on Sun, 18 Aug 2019 16:15:30 +0000)
> Date: Sun, 18 Aug 2019 16:15:30 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > If you want the arrow be displayed before the line's text, why didn't
> > you just put a before-string at the beginning of the line, instead of
> > implementing this in the display engine?
>
> I think it was to be able to use the same interface that the overlay
> arrow already uses, without having to reimplement a lot of it using
> before-strings.
I think it's a general consensus that the "overlay arrow" feature
should be walked away of, and at some point should be deprecated. I'd
prefer not to base new code on that kludge.
> > AFAIU, that would give you most of the patch for free, e.g. you
> > wouldn't need to mess with the set_cursor_from_row hair.
>
> Yes, there was set_cursor_from_row which I had to change. Somehow, only
> partially initialised glyphs got into it; they pointed to lisp strings,
> but with an offset of -1. This caused an error to be thrown, and the
> surrounding internal_condition_case_1 reentered the redisplay code in a
> loop, causing Emacs to hang. I'm not sure where they failed to get
> initialised, but the function is probably better with the workaround I
> put in.
This might mean there's a bug in the code that generates those glyphs.
One more reason not to implement this in the display code.
> But it may be worthwhile to be able to use the overlay arrow
> interface for "insertion type" arrows.
Any particular reason why this might be worth our while? Because I
don't see any.
Thanks.
next prev parent reply other threads:[~2019-08-18 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 13:48 [Patch]: Allow overlay arrows to be inserted before the text at column zero rather than splatting it Alan Mackenzie
2019-08-18 14:34 ` Eli Zaretskii
2019-08-18 16:15 ` Alan Mackenzie
2019-08-18 16:29 ` Eli Zaretskii [this message]
2019-08-18 18:43 ` Alan Mackenzie
2019-08-18 18:53 ` Eli Zaretskii
2019-08-18 19:23 ` Alan Mackenzie
2019-08-19 2:29 ` Eli Zaretskii
2019-08-19 19:28 ` Alan Mackenzie
2019-08-20 2:30 ` Eli Zaretskii
2019-08-18 19:30 ` Noam Postavsky
2019-08-18 19:43 ` Alan Mackenzie
2019-08-19 9:30 ` Stefan Monnier
2019-08-19 14:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imqumo7i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.