From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24649: 24.5; Why no standard error for "Trailing garbage following expression"? Date: Fri, 23 Aug 2019 11:06:50 +0300 Message-ID: <83imqob90l.fsf@gnu.org> References: <58b6fb05-499d-4406-9bac-9c0889a588b8@default> <875znnh8if.fsf@mouse.gnus.org> <8736hsbuda.fsf@mouse.gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202162"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 24649@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 10:07:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i14bH-000qTE-NH for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 10:07:11 +0200 Original-Received: from localhost ([::1]:52560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i14bG-0008WB-Lx for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 04:07:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39787) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i14b9-0008W1-Vy for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i14b9-0000KC-11 for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58502) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i14b8-0000Jp-0n for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i14b7-0007qh-Q2 for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 04:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 08:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 24649-submit@debbugs.gnu.org id=B24649.156654760930152 (code B ref 24649); Fri, 23 Aug 2019 08:07:01 +0000 Original-Received: (at 24649) by debbugs.gnu.org; 23 Aug 2019 08:06:49 +0000 Original-Received: from localhost ([127.0.0.1]:39090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i14au-0007qG-SC for submit@debbugs.gnu.org; Fri, 23 Aug 2019 04:06:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i14as-0007q3-RP for 24649@debbugs.gnu.org; Fri, 23 Aug 2019 04:06:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i14an-0000Af-Ft; Fri, 23 Aug 2019 04:06:41 -0400 Original-Received: from [176.228.60.248] (port=3578 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i14am-0001e0-Ge; Fri, 23 Aug 2019 04:06:41 -0400 In-reply-to: <8736hsbuda.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Fri, 23 Aug 2019 02:25:37 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165671 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 23 Aug 2019 02:25:37 +0200 > Cc: 24649@debbugs.gnu.org > > >> Shouldn't this error be a standard error? If not a new standard error, > >> shouldn't it at least use one of the existing standard errors, such as > >> `scan-error' or `invalid-read-syntax'? > >> > >> Otherwise, how to easily handle this error (e.g., to tell the user to > >> correct the input being read and then read again)? > > > > Makes sense to me. I'm not sure what signal to use, though -- anybody > > got an idea? > > [...] > > > + xsignal1 (Qinvalid_read_syntax, > > + build_string ("Trailing garbage following expression")); > > There weren't any comments, so I've now applied this. If somebody has a > better idea for the error signal, please amend. Thanks, but this change needs to be reflected in the ELisp manual, where currently invalid-read-syntax is documented for a different use case.