From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file Date: Fri, 30 Aug 2019 15:19:51 +0300 Message-ID: <83imqealqw.fsf@gnu.org> References: <87a7ic9due.fsf@gnu.org> <87muhnrwvs.fsf@mouse.gnus.org> <875zmk5r5u.fsf@gnus.org> <83sgpofjc9.fsf@gnu.org> <87k1b04a3x.fsf@gnus.org> <83pnksfel0.fsf@gnu.org> <87v9uj2i7l.fsf@gnus.org> <83mufvdomu.fsf@gnu.org> <87ftln2f0f.fsf@gnus.org> <83imqjdmqb.fsf@gnu.org> <8736hn2clq.fsf@gnus.org> <83ef16ewpj.fsf@gnu.org> <87k1avhtm0.fsf@gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135992"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34720@debbugs.gnu.org, dunni@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 30 15:28:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i3gx0-000ZFS-C1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Aug 2019 15:28:26 +0200 Original-Received: from localhost ([::1]:58634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3gwy-0005Rn-SF for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Aug 2019 09:28:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38858) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i3grs-0002al-RB for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 09:23:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i3grp-00050x-JF for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 09:23:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i3grp-0004ww-EJ for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 09:23:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i3grm-0001wf-8a for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2019 09:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Aug 2019 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed confirmed Original-Received: via spool by 34720-submit@debbugs.gnu.org id=B34720.15671713727440 (code B ref 34720); Fri, 30 Aug 2019 13:23:02 +0000 Original-Received: (at 34720) by debbugs.gnu.org; 30 Aug 2019 13:22:52 +0000 Original-Received: from localhost ([127.0.0.1]:53455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3grc-0001vn-ET for submit@debbugs.gnu.org; Fri, 30 Aug 2019 09:22:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i3grX-0001vR-Eb for 34720@debbugs.gnu.org; Fri, 30 Aug 2019 09:22:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i3grR-0003Bt-8K; Fri, 30 Aug 2019 09:22:41 -0400 Original-Received: from [176.228.60.248] (port=4458 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i3fsW-0007Tz-85; Fri, 30 Aug 2019 08:19:44 -0400 In-reply-to: <87k1avhtm0.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 30 Aug 2019 11:48:07 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166091 Archived-At: > From: Lars Ingebrigtsen > Cc: 34720@debbugs.gnu.org, dunni@gnu.org > Date: Fri, 30 Aug 2019 11:48:07 +0200 > > Eli Zaretskii writes: > > >> So the fix here is to make epa follow the same logic, perhaps? That is, > >> first get the text we're supposed to insert, then compare with the data > >> in the buffer, and only start replacing at the point where we find the > >> first difference? > > > > You want to replace the insert-file-contents with custom-tailored Lisp > > code? Even if possible and efficient enough, this would be a > > specialized solution for only a single use case. Right? Other use > > cases, with other insert-file-contents handlers, will each one have to > > have their separate custom solutions, right? All that just to keep > > markers intact? > > It's a problem common to all the insert-file-content handlers, I think? > Now that I understand what the problem is (i.e., "don't replace the text > at the start of the buffer with identical text"), I think fixing this in > the epa case should hopefully be easy enough, and perhaps something more > general can be extracted from that solution. Which I have not written > yet, so we'll see. :-) The problem is that getting at the new text to compare with is specific to each handler, and some of them cannot be rewound (i.e., you cannot examine the same text more than once).