From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Returning argument string (regexp-quote) Date: Tue, 24 Sep 2019 22:47:19 +0300 Message-ID: <83impho4s8.fsf@gnu.org> References: <83sgoloedi.fsf@gnu.org> <658AF539-1AE7-459D-94C7-44970AA94EEF@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="115941"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 24 21:48:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCqn9-000U2I-Ss for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2019 21:48:08 +0200 Original-Received: from localhost ([::1]:50260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqn7-0007B3-4z for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2019 15:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35565) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCqmU-0006nX-7F for emacs-devel@gnu.org; Tue, 24 Sep 2019 15:47:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iCqmT-0006MG-Qm; Tue, 24 Sep 2019 15:47:25 -0400 Original-Received: from [176.228.60.248] (port=4142 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iCqmS-00024Y-P1; Tue, 24 Sep 2019 15:47:25 -0400 In-reply-to: <658AF539-1AE7-459D-94C7-44970AA94EEF@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 24 Sep 2019 19:44:21 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240282 Archived-At: > From: Mattias Engdegård > Date: Tue, 24 Sep 2019 19:44:21 +0200 > Cc: emacs-devel@gnu.org > > What about the specific case of regexp-quote then? I think we could do that in this case. > It was responsible for a sizeable portion of local consing in some (non-public) code I was profiling. "Sizable portion" meaning what, in quantitative terms? > Would the change need a mention in NEWS, and/or its doc string? I think it should be in NEWS and in the ELisp manual. Doc string doesn't necessarily have to say that (although it isn't a catastrophe if it does), given its current language. Thanks.