From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Falling to build Date: Wed, 01 Jan 2020 19:22:38 +0200 Message-ID: <83imlvjdlt.fsf@gnu.org> References: <9118-Wed01Jan2020163405+0000-jpff@codemist.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="131374"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: John Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 01 18:22:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1imhhv-000Y2u-4C for ged-emacs-devel@m.gmane.org; Wed, 01 Jan 2020 18:22:55 +0100 Original-Received: from localhost ([::1]:60330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imhhu-00019Y-02 for ged-emacs-devel@m.gmane.org; Wed, 01 Jan 2020 12:22:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52601) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imhhS-0000gV-6d for emacs-devel@gnu.org; Wed, 01 Jan 2020 12:22:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imhhR-0008Vt-Pt; Wed, 01 Jan 2020 12:22:25 -0500 Original-Received: from [176.228.60.248] (port=4069 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imhhR-0001m8-1e; Wed, 01 Jan 2020 12:22:25 -0500 In-reply-to: <9118-Wed01Jan2020163405+0000-jpff@codemist.co.uk> (message from John on Wed, 1 Jan 2020 16:34:05 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243845 Archived-At: > Date: Wed, 1 Jan 2020 16:34:05 +0000 > From: John > > This morning all OK in building on openSuSe x86_64 until this happens > > CC xfns.o > xfns.c: In function ‘Fx_display_monitor_attributes_list’: > xfns.c:5072:30: warning: implicit declaration of function ‘x_get_net_workarea’; did you mean ‘x_set_undecorated’? [-Wimplicit-function-declaration] > if (i == primary_monitor && x_get_net_workarea (dpyinfo, &workarea_r)) > ^~~~~~~~~~~~~~~~~~ > x_set_undecorated > xfns.c:5072:30: warning: nested extern declaration of ‘x_get_net_workarea’ [-Wnested-externs] Does the patch below fix this? diff --git a/src/xfns.c b/src/xfns.c index b94666d..d0d5d39 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -4572,7 +4572,7 @@ DEFUN ("x-display-save-under", Fx_display_save_under, return Qnil; } -#ifndef USE_GTK +#if !defined USE_GTK || !defined HAVE_GTK3 /* Store the geometry of the workarea on display DPYINFO into *RECT. Return false if and only if the workarea information cannot be