From: Eli Zaretskii <eliz@gnu.org>
To: enometh@meer.net, martin rudalics <rudalics@gmx.at>
Cc: 39977@debbugs.gnu.org
Subject: bug#39977: 28.0.50; Unhelpful stack trace
Date: Fri, 13 Mar 2020 11:55:26 +0200 [thread overview]
Message-ID: <83imj88tpt.fsf@gnu.org> (raw)
In-Reply-To: <83zhcs80e5.fsf@gnu.org> (message from Eli Zaretskii on Sat, 07 Mar 2020 20:50:42 +0200)
Ping! Can you please try the proposed patch?
Martin, any thoughts or comments about this?
> Date: Sat, 07 Mar 2020 20:50:42 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 39977@debbugs.gnu.org
>
> > From: Madhu <enometh@meer.net>
> > Date: Sat, 07 Mar 2020 23:13:16 +0530
> >
> > Thanks Eli, Following up on the emacs-devel message, I recompiled emacs
> > and get substantially the same stack trace. This is with my ~/.emacs and
> > all my local customizations loaded.
> >
> > when evaluating a form in a sly lisp buffer with
> > (break)
> > M-x sly-eval-last-sexp
> > pops up a sly debug window in a new frame
> > quitting the window (and frame) tries to select the previous window
> > and the crash apparently happens at this point. I'm attaching the
> > backtraces as attachments
> >
> > With a little guidance I expect to be able to investigate this further
>
> Thanks. Please try the patch below, and tell if it makes the crash
> go away.
>
> diff --git a/src/window.c b/src/window.c
> index 8cdad27..863fac4 100644
> --- a/src/window.c
> +++ b/src/window.c
> @@ -541,8 +541,11 @@ select_window (Lisp_Object window, Lisp_Object norecord,
> else
> redisplay_other_windows ();
>
> - sf = SELECTED_FRAME ();
> - if (XFRAME (WINDOW_FRAME (w)) != sf)
> + if (FRAMEP (selected_frame) && FRAME_LIVE_P (XFRAME (selected_frame)))
> + sf = XFRAME (selected_frame);
> + else
> + sf = NULL;
> + if (!sf || XFRAME (WINDOW_FRAME (w)) != sf)
> {
> fset_selected_window (XFRAME (WINDOW_FRAME (w)), window);
> /* Use this rather than Fhandle_switch_frame
>
>
>
>
next prev parent reply other threads:[~2020-03-13 9:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 17:43 bug#39977: 28.0.50; Unhelpful stack trace Madhu
2020-03-07 18:50 ` Eli Zaretskii
2020-03-13 9:55 ` Eli Zaretskii [this message]
2020-03-13 16:28 ` martin rudalics
2020-03-13 19:43 ` Eli Zaretskii
2020-03-14 8:48 ` martin rudalics
2020-03-14 10:10 ` Eli Zaretskii
2020-03-14 10:37 ` martin rudalics
2020-03-14 18:55 ` martin rudalics
2020-03-14 20:09 ` Eli Zaretskii
2020-03-15 17:49 ` martin rudalics
2020-03-15 18:41 ` Eli Zaretskii
2020-03-16 9:24 ` martin rudalics
2020-03-16 15:33 ` Eli Zaretskii
2020-03-17 9:38 ` martin rudalics
2020-03-17 15:51 ` Eli Zaretskii
2020-03-17 17:31 ` martin rudalics
2020-03-17 17:45 ` Eli Zaretskii
2020-03-17 18:39 ` martin rudalics
2020-03-17 19:41 ` Eli Zaretskii
2020-03-18 9:12 ` martin rudalics
2020-03-18 14:53 ` Eli Zaretskii
2020-03-18 18:48 ` martin rudalics
2020-03-18 19:36 ` Eli Zaretskii
2020-03-19 8:55 ` martin rudalics
2020-03-19 14:33 ` Eli Zaretskii
2020-03-21 9:32 ` martin rudalics
2020-03-21 13:15 ` Eli Zaretskii
2020-03-22 18:20 ` martin rudalics
2020-03-23 14:48 ` Eli Zaretskii
2020-03-24 9:45 ` martin rudalics
2020-03-28 8:23 ` Eli Zaretskii
2020-03-28 18:38 ` martin rudalics
2020-04-03 16:32 ` martin rudalics
2020-04-10 11:51 ` Madhu
2020-09-30 15:06 ` Lars Ingebrigtsen
2020-09-30 15:31 ` Eli Zaretskii
2020-09-30 17:29 ` martin rudalics
2020-10-01 0:01 ` Lars Ingebrigtsen
2020-10-01 4:37 ` Madhu
2020-03-19 3:48 ` Madhu
2020-03-16 2:42 ` Madhu
2020-03-16 9:25 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imj88tpt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=39977@debbugs.gnu.org \
--cc=enometh@meer.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.