From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE Date: Sat, 04 Apr 2020 21:25:20 +0300 Message-ID: <83imift8fj.fsf@gnu.org> References: <805F9723-8298-4FD7-A47B-1E683721A5B0@acm.org> <835zegwn9y.fsf@gnu.org> <83imifv96b.fsf@gnu.org> <42EFD1AE-A96E-4613-A31E-C3723382DC6D@acm.org> <83r1x3tc6c.fsf@gnu.org> <1C9D87C7-57DD-4C61-86FE-99A7095E5085@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="12287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40407@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 04 20:26:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKnUh-00034w-Ot for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Apr 2020 20:26:11 +0200 Original-Received: from localhost ([::1]:41392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKnUg-00079G-Nq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Apr 2020 14:26:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41514) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKnUZ-000795-Ix for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKnUY-0008Ve-Kz for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKnUY-0008VW-Hy for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKnUY-0008FS-Dz for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 14:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Apr 2020 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40407-submit@debbugs.gnu.org id=B40407.158602474631646 (code B ref 40407); Sat, 04 Apr 2020 18:26:02 +0000 Original-Received: (at 40407) by debbugs.gnu.org; 4 Apr 2020 18:25:46 +0000 Original-Received: from localhost ([127.0.0.1]:44818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKnUI-0008EL-5A for submit@debbugs.gnu.org; Sat, 04 Apr 2020 14:25:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKnUG-0008Dw-PN for 40407@debbugs.gnu.org; Sat, 04 Apr 2020 14:25:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jKnUB-0007mL-E8; Sat, 04 Apr 2020 14:25:39 -0400 Original-Received: from [176.228.60.248] (port=2131 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jKnU8-0006MY-0E; Sat, 04 Apr 2020 14:25:38 -0400 In-Reply-To: <1C9D87C7-57DD-4C61-86FE-99A7095E5085@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sat, 4 Apr 2020 20:01:12 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178039 Archived-At: > From: Mattias Engdegård > Date: Sat, 4 Apr 2020 20:01:12 +0200 > Cc: 40407@debbugs.gnu.org > > 4 apr. 2020 kl. 19.04 skrev Eli Zaretskii : > > > How so? > > Because then NOCOPY suddenly matters for almost all coding systems, not just nil. After all, an all-ASCII input string and ASCII-compatible coding is not an unusual combination. This forces us to be careful when correcting the NOCOPY sense, and may expose latent bugs. That's true. But as a matter of fact, I don't see any calls to code_convert_string with NOCOPY non-zero, they all pass zero or false to it. So none of the existing direct calls from C wants or expects to get the same string. > But you are right: we should trust calls to {en,de}code-coding-system with NOCOPY=t, and the rest can also remain as they are until someone cares enough to change them. Agreed. Btw, this bug was introduced in commit 4031e2b, 18 years ago.