From: Eli Zaretskii <eliz@gnu.org>
To: Simon Lang <Simon.lang@outlook.com>
Cc: contovob@tcd.ie, 41766@debbugs.gnu.org, dgutov@yandex.ru,
juri@linkov.net
Subject: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization
Date: Sat, 13 Jun 2020 09:50:16 +0300 [thread overview]
Message-ID: <83imfv4fyv.fsf@gnu.org> (raw)
In-Reply-To: <VI1PR10MB2800B2C5F05EE46D4D71180080830@VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM> (message from Simon Lang on Wed, 10 Jun 2020 21:11:09 +0000)
> From: Simon Lang <Simon.lang@outlook.com>
> CC: "41766@debbugs.gnu.org" <41766@debbugs.gnu.org>, "dgutov@yandex.ru"
> <dgutov@yandex.ru>, "juri@linkov.net" <juri@linkov.net>
> Date: Wed, 10 Jun 2020 21:11:09 +0000
>
> I now something to the manual, NEWS and changed the doc string + commit msg as advised. I decided on defcustom in the end because this way it is easy for the user to figure out what goes wrong in case he/she modifies grep-command and highlighting is missing. Hope that is fine.
>
> Pls let me know if there is anything else I need to change.
Thanks, a few minor comments below.
> +by grep. The matching of the sequences is controlled by
> +@code{grep-match-regexp}, which can be customize to accommodate
> +different grep programs. ^^^^^^^^^
Typo: should be "customized".
Also, "grep" should be "Grep".
> +** Grep changes:
> +
> +*** New variable 'grep-match-regexp' matches grep markers to highlight.
> +Grep emits SGR ANSI escape sequences to color its output. The new variable
> +'grep-match-regexp' holds the regular expression to match the appropriate
> +markers in order to provide highlighting in the source buffer. The variable
> +can be customized to accommodate other grep-like tools.
Please leave 2 spaces between sentences, per our conventions.
> +(defcustom grep-match-regexp "\033\\[0?1;31m\\(.*?\\)\033\\[[0-9]*m"
> + "Regular expression matching grep markers to highlight.
> +It matches SGR ANSI escape sequences which are emitted by grep to
> +color its output. This variable is used in `grep-filter'."
Likewise here.
next prev parent reply other threads:[~2020-06-13 6:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 20:25 bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization Simon Lang
2020-06-08 23:18 ` Juri Linkov
2020-06-09 0:44 ` Dmitry Gutov
2020-06-09 7:58 ` Simon Lang
2020-06-09 11:55 ` Basil L. Contovounesios
2020-06-09 12:45 ` Simon Lang
2020-06-09 14:32 ` Basil L. Contovounesios
2020-06-09 14:43 ` Eli Zaretskii
2020-06-10 21:11 ` Simon Lang
2020-06-10 21:52 ` Juri Linkov
2020-06-10 22:14 ` Dmitry Gutov
2020-06-10 23:10 ` Juri Linkov
2020-06-10 23:24 ` Dmitry Gutov
2020-06-13 9:51 ` Simon Lang
2020-06-13 22:50 ` Juri Linkov
2020-06-13 6:50 ` Eli Zaretskii [this message]
2020-06-13 9:48 ` Simon Lang
2020-09-27 12:56 ` Lars Ingebrigtsen
2020-06-09 12:15 ` Dmitry Gutov
2020-06-09 12:41 ` Simon Lang
2020-06-09 14:24 ` Eli Zaretskii
[not found] <0e6ad4aefa2743f1b0d6ba4315a9e91b@VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM>
2020-06-14 9:12 ` Simon Lang
2020-06-14 23:08 ` Juri Linkov
2020-06-22 19:09 ` Simon Lang
2020-06-22 23:50 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imfv4fyv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41766@debbugs.gnu.org \
--cc=Simon.lang@outlook.com \
--cc=contovob@tcd.ie \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.