From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Mon, 05 Oct 2020 14:33:44 +0300 Message-ID: <83imbodi07.fsf@gnu.org> References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> <83blhhdy3w.fsf@gnu.org> <87d01xghmt.fsf@gmail.com> <83sgatc8er.fsf@gnu.org> <83mu11c78j.fsf@gnu.org> <87tuv9eygk.fsf@gmail.com> <83k0w5c4yt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33691"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spacibba@aol.com, juri@linkov.net, casouri@gmail.com, joaotavora@gmail.com, emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 05 13:34:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPOlS-0008Z9-53 for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 13:34:46 +0200 Original-Received: from localhost ([::1]:50026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPOlR-0007vX-76 for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 07:34:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPOkU-00071v-2g for emacs-devel@gnu.org; Mon, 05 Oct 2020 07:33:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56891) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPOkS-00072A-VM; Mon, 05 Oct 2020 07:33:44 -0400 Original-Received: from [176.228.60.248] (port=1779 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPOkR-0000d0-US; Mon, 05 Oct 2020 07:33:44 -0400 In-Reply-To: (message from Gregory Heytings on Mon, 05 Oct 2020 11:11:28 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257109 Archived-At: > Date: Mon, 05 Oct 2020 11:11:28 +0000 > From: Gregory Heytings > cc: João Távora , spacibba@aol.com, > emacs-devel@gnu.org, casouri@gmail.com, juri@linkov.net > > > Not sure what should be canonical here. AFAIU, just using > > window-text-pixel-size and comparing with the window dimensions is all > > that's needed. > > Just calculating the window dimensions is already a nontrivial task. > There are two cases: a miniwindow-only frame, and the "normal" case. In > the first case you need to use frame-height, and multiply it with the > pixel height of the "default" face. In the second case you can get the > maximal dimensions with max-mini-window-height, and multiply it by the > pixel height of the "default" face. But you cannot just multiply > max-mini-window-height by that height, that would be too easy. There are > again two cases: either max-mini-window-height is an integer, in which > case you can just do that multiplication, or it is a floating point > number, in which case you have to multiply that number by frame-height and > truncate it, and multiply the resulting number by the pixel height of the > "default" face... Well, if someone wants to write a function which does all that, I'm sure it will be welcome (assuming that window.el doesn't yet have something like that already).