all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Evgeny Zajcev <zevlg@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property
Date: Sat, 26 Dec 2020 11:19:56 +0200	[thread overview]
Message-ID: <83im8oncub.fsf@gnu.org> (raw)
In-Reply-To: <CAO=W_Zpvfn+bLmMKrQmtCEcXbTV819rXVaWRpKabS_jgb6AQyw@mail.gmail.com> (message from Evgeny Zajcev on Sat, 19 Dec 2020 15:24:38 +0300)

> From: Evgeny Zajcev <zevlg@yandex.ru>
> Date: Sat, 19 Dec 2020 15:24:38 +0300
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
>  Do you think the current NEWS entry is sufficiently complete and
>  accurate?
> 
> Yeah, NEWS entries are good
> 
>  The patch LGTM, with a couple of wording nits:
> 
>  > * doc/lispref/display.texi: Add more documentation for `:base-uri'
> 
>  This should mention the name of the @node where the change is done, in
>  parentheses (as if it were a function).
> 
>  > diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi
>  > index 2b3119ea59..2ecd14fed9 100644
>  > --- a/doc/lispref/display.texi
>  > +++ b/doc/lispref/display.texi
>  > @@ -5904,7 +5904,13 @@ SVG Images
>  >  To @var{svg} add an embedded (raster) image placed at
>  >  @var{relative-filename}.  @var{relative-filename} is searched inside
>  >  @code{file-name-directory} of the @code{:base-uri} svg image property.
>  > -This improves the performance of embedding large images.
>  > +@code{:base-uri} specifies a (possible non-existing) filename name of
>                                   ^^^^^^^^               ^^^^^^^^^^^^^
>  "possibly" and "file name".
> 
> Noted, here is the updated patch 

Thanks, pushed to the master branch.



  reply	other threads:[~2020-12-26  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.1938.1607798832.19112.emacs-diffs@gnu.org>
2020-12-12 19:42 ` master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property Eli Zaretskii
2020-12-12 20:42   ` Evgeny Zajcev
2020-12-13 15:05     ` Eli Zaretskii
2020-12-16 22:08       ` Evgeny Zajcev
2020-12-19 10:09         ` Eli Zaretskii
2020-12-19 12:24           ` Evgeny Zajcev
2020-12-26  9:19             ` Eli Zaretskii [this message]
     [not found] <20201212124845.19694.69782@vcs0.savannah.gnu.org>
     [not found] ` <20201212124847.8879221335@vcs0.savannah.gnu.org>
2020-12-12 22:43   ` Lars Ingebrigtsen
2020-12-12 23:59     ` Alan Third
2020-12-13 12:53       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83im8oncub.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=zevlg@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.