Re: master 99c276b 2/2: Revert "Preload paren.el"

Re: master 99c276b 2/2: Revert "Preload paren.el"

[Eli Zaretskii]

> branch: master
> commit 99c276b3c0aee5599c1d281c1e9fe223810784ca
> Author: Andrea Corallo <akrl@sdf.org>
> Commit: Andrea Corallo <akrl@sdf.org>
> 
>     Revert "Preload paren.el"
>     
>     Reverting as the previous commit make this fix not anymore necessary.

Andrea, I don't understand this commit.  We preload paren.el because
we now turn on show-paren-mode by default.  After this commit, I get
an error message in this scenario:

  emacs -Q
  M-: (foo)

As soon as I type the right parenthesis, Emacs complains:

  blink-paren-post-self-insert-function: Symbol’s value as variable is void: show-paren-mode

Your fix perhaps prevented the need for natively-compiling the
prerequisites of paren.el, but we should still preload it.

Re: master 99c276b 2/2: Revert "Preload paren.el"

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> branch: master
>> commit 99c276b3c0aee5599c1d281c1e9fe223810784ca
>> Author: Andrea Corallo <akrl@sdf.org>
>> Commit: Andrea Corallo <akrl@sdf.org>
>> 
>>     Revert "Preload paren.el"
>>     
>>     Reverting as the previous commit make this fix not anymore necessary.
>
> Andrea, I don't understand this commit.  We preload paren.el because
> we now turn on show-paren-mode by default.  After this commit, I get
> an error message in this scenario:
>
>   emacs -Q
>   M-: (foo)
>
> As soon as I type the right parenthesis, Emacs complains:
>
>   blink-paren-post-self-insert-function: Symbol’s value as variable is void: show-paren-mode
>
> Your fix perhaps prevented the need for natively-compiling the
> prerequisites of paren.el, but we should still preload it.

Sincere apologies for the breakage, I erroneously thought the reverted
commit was only about the circular dependency issue we discussed
sometime ago.

Should be fixed by a7dfb2acfc

Best Regards

  Andrea

Re: master 99c276b 2/2: Revert "Preload paren.el"

[Eli Zaretskii]

> From: Andrea Corallo <akrl@sdf.org>
> Cc: emacs-devel@gnu.org
> Date: Tue, 30 Nov 2021 18:17:46 +0000
> 
> >   emacs -Q
> >   M-: (foo)
> >
> > As soon as I type the right parenthesis, Emacs complains:
> >
> >   blink-paren-post-self-insert-function: Symbol’s value as variable is void: show-paren-mode
> >
> > Your fix perhaps prevented the need for natively-compiling the
> > prerequisites of paren.el, but we should still preload it.
> 
> Sincere apologies for the breakage, I erroneously thought the reverted
> commit was only about the circular dependency issue we discussed
> sometime ago.
> 
> Should be fixed by a7dfb2acfc

Thanks, it's indeed fixed.