From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53598: 28.0.91; occur-after-change function errors with args-out-of-range in occur-edit-mode Date: Fri, 28 Jan 2022 16:27:57 +0200 Message-ID: <83ilu4c4uq.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3760"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53598@debbugs.gnu.org To: Jack Henahan , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 28 16:07:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDSqq-0000m4-I1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jan 2022 16:07:48 +0100 Original-Received: from localhost ([::1]:54562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDSqp-0002QZ-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jan 2022 10:07:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDSFJ-0006SL-Ul for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 09:29:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDSFJ-0004L9-K9 for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 09:29:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDSFJ-0004Vv-I1 for bug-gnu-emacs@gnu.org; Fri, 28 Jan 2022 09:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jan 2022 14:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53598 X-GNU-PR-Package: emacs Original-Received: via spool by 53598-submit@debbugs.gnu.org id=B53598.164338009817288 (code B ref 53598); Fri, 28 Jan 2022 14:29:01 +0000 Original-Received: (at 53598) by debbugs.gnu.org; 28 Jan 2022 14:28:18 +0000 Original-Received: from localhost ([127.0.0.1]:57940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDSET-0004UZ-7R for submit@debbugs.gnu.org; Fri, 28 Jan 2022 09:28:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDSER-0004U3-5T for 53598@debbugs.gnu.org; Fri, 28 Jan 2022 09:28:07 -0500 Original-Received: from [2001:470:142:3::e] (port=56058 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDSEL-0004By-G2; Fri, 28 Jan 2022 09:28:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GaIGAXilure1e9JD95MdL4calhlQNBsFFnxGZ3Vwvh0=; b=bo0whPS0Q6/xt55eyW0k 5Vj5s7e6A96kcSDx2S7OZMOlBBTuazCugCQuiQWtowyOt5Si1SaEnBhAJ3If7kuOi6yGslnf8hgim b7oB8g2Nbw1x7rsJ/MMC6pzoEyq95myWXXfgy9Bw0PUmqgh/ehDUkuRzmO/p3Z+65QGV70+pg3InW yMmBuZ2QW8xJsHvr8xFPBnuIDmrvCUmKCkKI5pGT26lDf+EjN47UdZryM+kX1RR8AIOJXGYgyA7+c VTO8quUYcvuaiNZ2CJVxzEqveVr2ruB05bDbQWxzn6nrQgKcTyCvzCcCf1vujIB2JnziSFeon/7Wj f46n29O5RRWRxQ==; Original-Received: from [87.69.77.57] (port=2642 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDSEK-0000hD-IK; Fri, 28 Jan 2022 09:28:01 -0500 In-Reply-To: (message from Jack Henahan on Fri, 28 Jan 2022 07:28:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225460 Archived-At: > Date: Fri, 28 Jan 2022 07:28:47 +0000 > From: Jack Henahan > > >From `emacs -Q': > > M-x toggle-debug-on-error > M-s o buffer RET > C-x o > C-s buffer C-s C-s RET > e > DEL DEL DEL > > Debugger entered--Lisp error: (args-out-of-range ";; This buf is for text that is not saved, and for..." 11 -57) > occur-after-change-function(64 64 1) > delete-backward-char(1 nil) > funcall-interactively(delete-backward-char 1 nil) > command-execute(delete-backward-char) > > Similar stack traces arise if you choose an arbitrary place in an > occurrence and, say > > M-d M-d M-d Thanks. Does the patch below give good results? diff --git a/lisp/replace.el b/lisp/replace.el index 45bd05d..a784388 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -1413,7 +1413,10 @@ occur-after-change-function (length s1))))) (prefix-len (funcall common-prefix buf-str text)) (suffix-len (funcall common-prefix - (reverse buf-str) (reverse text)))) + (reverse (substring + buf-str prefix-len)) + (reverse (substring + text prefix-len))))) (setq beg-pos (+ beg-pos prefix-len)) (setq end-pos (- end-pos suffix-len)) (setq text (substring text prefix-len (- suffix-len)))