Re: master 99c637499e: Only apply last change to the clipboard

Re: master 99c637499e: Only apply last change to the clipboard

[Stefan Monnier]

> @@ -173,6 +173,7 @@ decoded.  If `gui-get-selection' signals an error, return nil."
>    (unless (and (memq window-system '(x haiku))
>                 ;; gui-backend-selection-p might be unreliable on other
>                 ;; window systems.
> +               (eq type 'CLIPBOARD)
>                 (gui-backend-selection-owner-p type))
>      (let ((request-type (if (memq window-system '(x pgtk))
>                              (or x-select-request-type

The comment is weird.  Is it meant to apply to the line of code *above* it?
If so, please move it since we follow the convention to put comments
*before* the code to which they apply.  Also I suspect that you meant to
say `gui-backend-selection-owner-p` rather than
`gui-backend-selection-p` in the comment, right?

BTW rather than use such tests we should probably change
`gui-backend-selection-owner-p` so it can return yes/no/dontknow.


        Stefan

Re: master 99c637499e: Only apply last change to the clipboard

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> The comment is weird.  Is it meant to apply to the line of code
> *above* it?  If so, please move it since we follow the convention to
> put comments *before* the code to which they apply.

That will be fixed, thanks.

> Also I suspect that you meant to say `gui-backend-selection-owner-p`
> rather than `gui-backend-selection-p` in the comment, right?

Yes, thanks.

> BTW rather than use such tests we should probably change
> `gui-backend-selection-owner-p` so it can return yes/no/dontknow.

The problem is that I don't really know why it doesn't work on those
ports.  I just observed them returning nonsensical values.

Re: master 99c637499e: Only apply last change to the clipboard

[Po Lu]

Po Lu <luangruo@yahoo.com> writes:

> The problem is that I don't really know why it doesn't work on those
> ports.

"those ports" being PGTK and GNUstep.  Maybe it works correctly on
MS-Windows, so we could add `w32' to the list of window systems where it
does work.

Thanks.

Re: master 99c637499e: Only apply last change to the clipboard

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 01 Feb 2022 13:28:22 +0800
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > The problem is that I don't really know why it doesn't work on those
> > ports.
> 
> "those ports" being PGTK and GNUstep.  Maybe it works correctly on
> MS-Windows, so we could add `w32' to the list of window systems where it
> does work.

The notion of "selection owner" doesn't exist on MS-Windows, so maybe
I misunderstand what you mean by "works".  In any case, if you show
some recipe to try, I could try it and report back.

Re: master 99c637499e: Only apply last change to the clipboard

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> The notion of "selection owner" doesn't exist on MS-Windows, so maybe
> I misunderstand what you mean by "works".  In any case, if you show
> some recipe to try, I could try it and report back.

Thanks, you can just try saving some text to the clipboard, and then
running:

  (gui-backend-selection-owner-p 'CLIPBOARD)

Which should return t.  Then cut some text from another application, and
it should return nil.

Re: master 99c637499e: Only apply last change to the clipboard

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: monnier@iro.umontreal.ca,  emacs-devel@gnu.org
> Date: Wed, 02 Feb 2022 08:58:29 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > The notion of "selection owner" doesn't exist on MS-Windows, so maybe
> > I misunderstand what you mean by "works".  In any case, if you show
> > some recipe to try, I could try it and report back.
> 
> Thanks, you can just try saving some text to the clipboard, and then
> running:
> 
>   (gui-backend-selection-owner-p 'CLIPBOARD)
> 
> Which should return t.  Then cut some text from another application, and
> it should return nil.

It returns nil here in both cases.  This is with today's master.

Re: master 99c637499e: Only apply last change to the clipboard

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> It returns nil here in both cases.  This is with today's master.

Hmm, that means the result is not useful for `gui-selection-value'.
Would there be a way to implement that feature on MS-Windows?

The simplest way to implement it would be to return `t' if Emacs stored
the text currently in the clipboard.

Thanks.

Re: master 99c637499e: Only apply last change to the clipboard

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: monnier@iro.umontreal.ca,  emacs-devel@gnu.org
> Date: Wed, 02 Feb 2022 12:50:19 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > It returns nil here in both cases.  This is with today's master.
> 
> Hmm, that means the result is not useful for `gui-selection-value'.
> Would there be a way to implement that feature on MS-Windows?
> 
> The simplest way to implement it would be to return `t' if Emacs stored
> the text currently in the clipboard.

What would be the purpose of that?  What would you like to do with
"ownership" of the clipboard data, and why?

Emacs on Windows already tries internally to keep track of whether the
stuff in the clipboard was put there by the current session, so I'm
not sure why else would you need this.

Re: master 99c637499e: Only apply last change to the clipboard

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

>> Hmm, that means the result is not useful for `gui-selection-value'.
>> Would there be a way to implement that feature on MS-Windows?
>> 
>> The simplest way to implement it would be to return `t' if Emacs stored
>> the text currently in the clipboard.

> What would be the purpose of that?  What would you like to do with
> "ownership" of the clipboard data, and why?

That way, `gui-selection-value' can return nil if Emacs owns the
selection (per the doc string of `interprogram-paste-function') to avoid
fetching the selection in the common case where the user is yanking text
saved by Emacs.

> Emacs on Windows already tries internally to keep track of whether the
> stuff in the clipboard was put there by the current session, so I'm
> not sure why else would you need this.

See the doc string of `interprogram-paste-function':

  If no other program has provided text to paste, the function should
  return nil (in which case the caller, usually current-kill, should use
  the top of the Emacs kill ring)

Thanks.

Re: master 99c637499e: Only apply last change to the clipboard

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: monnier@iro.umontreal.ca,  emacs-devel@gnu.org
> Date: Wed, 02 Feb 2022 21:51:26 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Hmm, that means the result is not useful for `gui-selection-value'.
> >> Would there be a way to implement that feature on MS-Windows?
> >> 
> >> The simplest way to implement it would be to return `t' if Emacs stored
> >> the text currently in the clipboard.
> 
> > What would be the purpose of that?  What would you like to do with
> > "ownership" of the clipboard data, and why?
> 
> That way, `gui-selection-value' can return nil if Emacs owns the
> selection (per the doc string of `interprogram-paste-function') to avoid
> fetching the selection in the common case where the user is yanking text
> saved by Emacs.

But the Windows implementation of gui-selection-value already does
that.  Did you try it on Windows?

> > Emacs on Windows already tries internally to keep track of whether the
> > stuff in the clipboard was put there by the current session, so I'm
> > not sure why else would you need this.
> 
> See the doc string of `interprogram-paste-function':
> 
>   If no other program has provided text to paste, the function should
>   return nil (in which case the caller, usually current-kill, should use
>   the top of the Emacs kill ring)

The Windows build already lives up to that promise.  There's no need
for any additional code.

Re: master 99c637499e: Only apply last change to the clipboard

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> But the Windows implementation of gui-selection-value already does
> that.  Did you try it on Windows?

No, I didn't know that.

> The Windows build already lives up to that promise.  There's no need
> for any additional code.

Thanks, then there's nothing to do here.

Re: master 99c637499e: Only apply last change to the clipboard

[Stefan Monnier]

Po Lu [2022-02-03 09:11:15] wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>> But the Windows implementation of gui-selection-value already does
>> that.  Did you try it on Windows?
> No, I didn't know that.
>> The Windows build already lives up to that promise.  There's no need
>> for any additional code.
> Thanks, then there's nothing to do here.

FWIW, when I worked on this gui-selection code, I found this part quite
unclear, and hence in need of clarification/simplification.


        Stefan

Re: master 99c637499e: Only apply last change to the clipboard

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Wed, 02 Feb 2022 23:01:53 -0500
> 
> Po Lu [2022-02-03 09:11:15] wrote:
> > Eli Zaretskii <eliz@gnu.org> writes:
> >> But the Windows implementation of gui-selection-value already does
> >> that.  Did you try it on Windows?
> > No, I didn't know that.
> >> The Windows build already lives up to that promise.  There's no need
> >> for any additional code.
> > Thanks, then there's nothing to do here.
> 
> FWIW, when I worked on this gui-selection code, I found this part quite
> unclear, and hence in need of clarification/simplification.

By "this part" do you mean how w32 works, or do you mean the
selection-owner stuff in general?

Re: master 99c637499e: Only apply last change to the clipboard

[Stefan Monnier]

>> FWIW, when I worked on this gui-selection code, I found this part quite
>> unclear, and hence in need of clarification/simplification.
> By "this part" do you mean how w32 works, or do you mean the
> selection-owner stuff in general?

I mean the selection-owner stuff.


        Stefan

Re: master 99c637499e: Only apply last change to the clipboard

[Stefan Monnier]

>> The comment is weird.  Is it meant to apply to the line of code
>> *above* it?  If so, please move it since we follow the convention to
>> put comments *before* the code to which they apply.
>
> That will be fixed, thanks.
>
>> Also I suspect that you meant to say `gui-backend-selection-owner-p`
>> rather than `gui-backend-selection-p` in the comment, right?
>
> Yes, thanks.

Thanks for confirming.

>> BTW rather than use such tests we should probably change
>> `gui-backend-selection-owner-p` so it can return yes/no/dontknow.
> The problem is that I don't really know why it doesn't work on those
> ports.  I just observed them returning nonsensical values.

Even if we don't know why, it'd be cleaner to put it there than here.


        Stefan

Re: master 99c637499e: Only apply last change to the clipboard

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> The problem is that I don't really know why it doesn't work on those
>> ports.  I just observed them returning nonsensical values.
>
> Even if we don't know why, it'd be cleaner to put it there than here.

How would you know when it should return `dontknow', when there is no
way to determine if it's returning an incorrect value?

Re: master 99c637499e: Only apply last change to the clipboard

[Stefan Monnier]

Po Lu [2022-02-01 15:40:49] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> The problem is that I don't really know why it doesn't work on those
>>> ports.  I just observed them returning nonsensical values.
>> Even if we don't know why, it'd be cleaner to put it there than here.
> How would you know when it should return `dontknow', when there is no
> way to determine if it's returning an incorrect value?

Always?


        Stefan