From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default Date: Fri, 25 Feb 2022 14:16:01 +0200 Message-ID: <83ilt3qgzi.fsf@gnu.org> References: <87ilt3456u.fsf@cassou.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32932"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54156@debbugs.gnu.org To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 25 13:16:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNZWF-0008JA-SG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Feb 2022 13:16:19 +0100 Original-Received: from localhost ([::1]:54860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNZWE-0006i7-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Feb 2022 07:16:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNZVy-0006ed-H3 for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 07:16:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNZVy-0005PB-7B for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 07:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNZVy-0002Dq-4h for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 07:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Feb 2022 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54156 X-GNU-PR-Package: emacs Original-Received: via spool by 54156-submit@debbugs.gnu.org id=B54156.16457913578520 (code B ref 54156); Fri, 25 Feb 2022 12:16:02 +0000 Original-Received: (at 54156) by debbugs.gnu.org; 25 Feb 2022 12:15:57 +0000 Original-Received: from localhost ([127.0.0.1]:51480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNZVs-0002DM-Sd for submit@debbugs.gnu.org; Fri, 25 Feb 2022 07:15:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNZVr-0002D9-VM for 54156@debbugs.gnu.org; Fri, 25 Feb 2022 07:15:56 -0500 Original-Received: from [2001:470:142:3::e] (port=50458 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNZVj-0005KA-3P; Fri, 25 Feb 2022 07:15:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=clJxL2D3aPZoy2kHuEhJQ92vKYrPPzWzxjRnSYV67R8=; b=e4fH8w35FHgs yrFvkunLqPl1ENlCip6vOkbvC5ty5v+3Ao8t3WDsmEIDn5tOOsP362KFhJR+uJZoVycYctV0eCWvs 4KwvMqHsrRzPbD8/F7Eif253+D9NsvfAt/i8i0AJ7T/RkFblONqENSrfOokHFHEVsLh16+VvO8+MG oYewVbE2ablCETesI26QVYNnWGSe9KY9js8DeJLftuJaM87lPNjZZ0UdDGK4Vc2xH93+2PLD+xY6O ih1Lmbfd+aRzA8ztPxQyAupzMYc5W34CqKg2shqaLO4ZpbH8ejjmVFOX8PcWGRnyCDx4y31s79YzC OpTJk0KLwhMmvbk29annOw==; Original-Received: from [87.69.77.57] (port=4333 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNZVi-00085Y-II; Fri, 25 Feb 2022 07:15:46 -0500 In-Reply-To: <87ilt3456u.fsf@cassou.me> (message from Damien Cassou on Fri, 25 Feb 2022 11:21:45 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227626 Archived-At: > From: Damien Cassou > Date: Fri, 25 Feb 2022 11:21:45 +0100 > > I have this in my init.el file: > > (set-face-attribute 'finsit-javascript-html-tag-face nil :background nil) > > As you can see, the FRAME argument (the 2nd) is nil. The documentation > says: "If FRAME is nil, set the attributes for all existing frames, as > well as the default for new frames.". > > However, when creating a new frame the background of this face is > reset and I have to execute this line manually. Please show a complete recipe for reproducing the problem, starting from "emacs -Q". In particular, we need to see: . how that face was defined in the first place (defface or somesuch) . how you create a new frame > Workaround: > > (defun my/fix-finsit-javascript-html-tag-face () > "Remove the background of `finsit-javascript-html-tag-face'." > (set-face-attribute 'finsit-javascript-html-tag-face nil :background nil)) > > (add-hook 'server-after-make-frame-hook #'my/fix-finsit-javascript-html-tag-face) Since you set 'server-after-make-frame-hook', does this mean the problem happens only with emacsclient frames? If so, that is one more reason for providing a complete recipe for us to investigate. Thanks.