From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Timings for 'make check' with and without symbols with position Date: Sun, 27 Feb 2022 14:34:24 +0200 Message-ID: <83ilt0o5db.fsf@gnu.org> References: <83bkytpnyt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25376"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ofv@wanadoo.es, deng@randomsample.de, mattiase@acm.org, emacs-devel@gnu.org, gregory@heytings.org, larsi@gnus.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 27 13:35:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOImH-0006OX-8e for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Feb 2022 13:35:53 +0100 Original-Received: from localhost ([::1]:59908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOImG-0002X1-7F for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Feb 2022 07:35:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOIl7-0001nG-N4 for emacs-devel@gnu.org; Sun, 27 Feb 2022 07:34:42 -0500 Original-Received: from [2001:470:142:3::e] (port=49022 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOIl5-0006La-5v; Sun, 27 Feb 2022 07:34:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jUphrLPVdz64nBpghpRMcZODVFdJ5RKHsMzlawZ7x6w=; b=W4rdWtDMLAoo dP4oPiEtNJoO79/LAdjTzWwXOKb+UTidEkx1+AFTTKEnOwWZqrBjRK+Bsvr1PnQlVaa75nQ27iXmS m4ztrW21T2q0mVA2rEI3C7ZvvLVRYPfgcgJ+xOec46hWGeWs+HdsTovXznV6tv7RFxpKnh7x4Jr4u y1xWxfUimam5F2PPCBkCCEyXzWsml0vzdhGFGzDfiUwLwpiOen0Y8mS06GmKdEesHGCfZVMwWTgbE BMJd5A1a2yVgidCnPacjohCXDAEu35xg5iJG+Rz0m1FE9LA9MC8OmTAlsPM2zKitVYbQD9yi8nYpN 3X6DP4Cs6HwZRyyMwlFVeQ==; Original-Received: from [87.69.77.57] (port=4551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOIl4-0000Ws-JX; Sun, 27 Feb 2022 07:34:38 -0500 In-Reply-To: (message from Alan Mackenzie on Sun, 27 Feb 2022 12:15:14 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286719 Archived-At: > Date: Sun, 27 Feb 2022 12:15:14 +0000 > From: Alan Mackenzie > Cc: ofv@wanadoo.es, deng@randomsample.de, mattiase@acm.org, emacs-devel@gnu.org, > gregory@heytings.org, larsi@gnus.org > > Char-tables seem to have something to do with it. The perf output for > mark_char_table increase from 2.98% to 3.79%. Adding the 12.6% factor > onto the 3.79% gives us 4.27%. That's a factor of ~1.5 increase. > > I'm still slogging through the detailed output for mark_char_table, > which is not easy in the optimised build. I suspect that somehow, > somewhere, symbols with position have got themselves into a char-table, > and they take (a lot) longer to process than bare symbols (for which > mark_char_table is optimised). I've not yet managed to find such a > char-table though. We do have a few char-tables whose slots are symbols or include symbols. unicode-category-table is one, for example; composition-function-table is another. Thanks for working on this.