From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes
Date: Tue, 01 Mar 2022 15:10:51 +0200 [thread overview]
Message-ID: <83ilsxlsx0.fsf@gnu.org> (raw)
In-Reply-To: <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> (message from Jim Porter on Mon, 28 Feb 2022 09:47:54 -0800)
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Mon, 28 Feb 2022 09:47:54 -0800
> Cc: 54190@debbugs.gnu.org
>
> Here's a patch to fix this, with a test so it doesn't regress again. I
> also re-attached the doc fix for simplicity. Both should apply to the 28
> branch with no issues.
Thanks, installed on the emacs-28 branch. (But the markup in the
manual part was wrong; see my followup changes.)
> I'll try to figure out why `eshell-do-eval' expects quoted lambdas, but
> unless that's a really trivial problem, the method here is probably
> safer for the 28 branch. Besides, I'm now 4 or 5 steps removed from the
> patch I was *trying* to work on, so a quick fix here will help me get
> back on track.
>
> Longer term, I agree that rewriting `eshell-do-eval' in terms of
> generator.el would be good. I think there are some bugs with how local
> variable state is managed by `eshell-do-eval', but I haven't had a
> chance to investigate it in any detail yet.
Fine with me. It's up to you whether to close this bug or leave it
open until a better solution is found for master.
next prev parent reply other threads:[~2022-03-01 13:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 21:34 bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Jim Porter
2022-02-28 6:11 ` Jim Porter
2022-02-28 8:16 ` Jim Porter
2022-02-28 9:38 ` Lars Ingebrigtsen
2022-02-28 13:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-28 13:28 ` Eli Zaretskii
2022-02-28 17:47 ` Jim Porter
2022-03-01 13:10 ` Eli Zaretskii [this message]
2022-03-04 5:55 ` Jim Porter
2022-03-04 7:16 ` Eli Zaretskii
2022-03-04 13:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-04 18:04 ` Jim Porter
2022-09-06 11:28 ` Lars Ingebrigtsen
2022-09-07 3:50 ` Jim Porter
2022-09-07 3:59 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilsxlsx0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54190@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.