From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Fri, 26 Aug 2022 16:17:07 +0300 Message-ID: <83ilmf16wc.fsf@gnu.org> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <83sflj1dbo.fsf@gnu.org> <87fshjmeje.fsf@posteo.net> <83mtbr1b6l.fsf@gnu.org> <87tu5zky6k.fsf@posteo.net> <83lerb197w.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 57400@debbugs.gnu.org To: Antoine Kalmbach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 15:19:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRZF6-0003xT-By for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 15:19:24 +0200 Original-Received: from localhost ([::1]:42320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRZF4-0007al-UH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 09:19:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRZDn-0007Yy-NQ for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 09:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRZDm-0003Km-Mr for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 09:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRZDm-0002ve-6p for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 09:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2022 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166151982711186 (code B ref 57400); Fri, 26 Aug 2022 13:18:02 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 13:17:07 +0000 Original-Received: from localhost ([127.0.0.1]:52670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRZCq-0002uJ-KT for submit@debbugs.gnu.org; Fri, 26 Aug 2022 09:17:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRZCl-0002tj-HY for 57400@debbugs.gnu.org; Fri, 26 Aug 2022 09:17:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRZCg-0003FZ-8U; Fri, 26 Aug 2022 09:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6hMsKX2V3qmNAJWOZyuSAjBsm/lzrjPQZ/+zH90fLh4=; b=QDjl9SoLZ4FD AtLPRjFMq0vFaN4fgxYkO1RiLUmfEf6wHEQbdd/asaIyOcWsIMQoMRW/NEZJcVRA2VoI0J3dRjeoK 1OOPDaroaIsD6Warw+Oeu+uMbZmQgDgwRMHdzdP85MSv2teJJZCPVQCOg4tlwsyGVinlh/aNwFuqt HIrx20RjNpWV0W+XEkCGwWsTxu/2X4y8IBpPw7BEQOkQpDmwZgDOQQU3Gkki6uixKpT9es7n5pWUh Sk6+l1wIgQ8lRe/BEvRFm2L4v8/TiA0nd4IRZjXZVirgQwxcZAIj6lY2E69kpeKe6TqhF2coj3R1h A+BUDWkbGpdQRlL0fyJkGw==; Original-Received: from [87.69.77.57] (port=4774 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRZCf-0004el-O8; Fri, 26 Aug 2022 09:16:54 -0400 In-Reply-To: (message from Antoine Kalmbach on Fri, 26 Aug 2022 16:10:58 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240837 Archived-At: > From: Antoine Kalmbach > Cc: 57400@debbugs.gnu.org > Date: Fri, 26 Aug 2022 16:10:58 +0300 > > > What I do is invoke "M-|" and send the region to "git am". That > > requires myself to recognize the patches, not the MUA I use. > > If the patch is attached, you open the patch, mark it, and then M-| git > am, right? Yes (modulo "cd .." to the right directory). > The standard Git approach is to just pipe the whole message, > expecting the patch to be in the email directly. The patch attachments can all be shown inline, since they are text, and then you can pipe the entire message, yes. > Or even with attachments, can you actually mark the whole email buffer > and pipe that? I think I once did that, and it worked. Not sure. But if you intend to provide/improve what happens on the receiving end as well, then Emacs could filter the irrelevant parts from what it sends down the "git am" pipe. > > Do you intend to provide a VC front-end to applying the patch-set, as > > part of this job? Because if not, what happens on the receiving end > > is out of the scope of the feature we are discussing. > > Having a complementary `vc-apply-patch` wouldn't be a bad idea, but > I think we should do the sending part first. Fine by me. > > We should have a user option that doesn't require project.el > > (project.el can override it, of course). There should be no > > requirement to use project.el to send patches from VC. > > I think Philip means directory-local variables, not project.el. Once we have an option, it can be included in directory-local variables, right?