From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type Date: Sat, 12 Nov 2022 11:03:39 +0200 Message-ID: <83iljko87o.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24285"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59212@debbugs.gnu.org To: Gabriel , Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 12 10:04:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otmRE-00067E-25 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Nov 2022 10:04:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otmQx-0002GX-Hd; Sat, 12 Nov 2022 04:04:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otmQl-0002Ff-0X for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 04:04:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otmQk-0007eJ-IF for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 04:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otmQk-0002xl-79 for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 04:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 09:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59212-submit@debbugs.gnu.org id=B59212.166824382311361 (code B ref 59212); Sat, 12 Nov 2022 09:04:02 +0000 Original-Received: (at 59212) by debbugs.gnu.org; 12 Nov 2022 09:03:43 +0000 Original-Received: from localhost ([127.0.0.1]:47301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otmQQ-0002xB-WD for submit@debbugs.gnu.org; Sat, 12 Nov 2022 04:03:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otmQP-0002ww-5H for 59212@debbugs.gnu.org; Sat, 12 Nov 2022 04:03:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otmQJ-0007bH-8B; Sat, 12 Nov 2022 04:03:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RkTJwCeHCv+1BkGCET7fKJY/fjhA8kii6rCoz67zOjM=; b=mqtCpnmqG4c3 ZdbkxVZCENwD2UghHoSwy5/XNdT7KDgKnvDCf6aHtpWPeL2Mxg+a928FgxEuPxe1ZKJmOh4Ystgm/ 8gkbgOZPMFOSalCjx6fyhQiVk3cKmpzIOp1Z8I3Xs2IsjsalGqW2+dKvM+GBmqikEKgVJnUNqKeCa i60BbXuRvZerz8egUewiZ6vA0VeCd6w6dFl5pfV6/Jqin4TUDDkfpDKnKsNjVQe87ytd1UfOnvF9S 58PmCae57rGk1cTh2elk2VdwfT6hixyPHsz4GV7N6jAp1PKMjV7V7w8trbLrt1bP8he4MiZdXdwGe v5OeUbpQoSlqpI+m4JF7rw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otmQI-0005yR-FR; Sat, 12 Nov 2022 04:03:34 -0500 In-Reply-To: (message from Gabriel on Sat, 12 Nov 2022 05:56:22 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247641 Archived-At: > From: Gabriel > Date: Sat, 12 Nov 2022 05:56:22 -0300 > > Description: > Not a bug per se, but a suggestion for improvement in how Bookmark > displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659). > > Currently, bookmark-bmenu-list (C-x r l) displays a column named Type, > which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc) > except for regular files, in which an empty string is displayed. I > believe the current behavior could be improved by displaying a default > value ("Files") to make the interface more uniform, explicit and to > avoid confusion. > > Steps: > 1) emacs -Q > 2) M-x eshell > 3) C-x r m > 4) C-x C-f ~/foo.bar > 5) C-x r m > 6) C-x r b > > These steps will add two bookmarks (eshell and foo.bar) and will open > the Bookmarks list. The Type column will have values "" and > "Eshell". After the patch below is applied, the Type column will have > values "File" and "Eshell". Thanks. Karl, any comments?